Skip to content

Fix never_loop forget to remove break in suggestion#15064

Merged
blyxyas merged 1 commit intorust-lang:masterfrom
profetia:issue15007
Jul 20, 2025
Merged

Fix never_loop forget to remove break in suggestion#15064
blyxyas merged 1 commit intorust-lang:masterfrom
profetia:issue15007

Conversation

@profetia
Copy link
Member

@profetia profetia commented Jun 16, 2025 •
edited by blyxyas
Loading

Closes #15007

Removes the break stmt and the dead code after it when appropriate.

changelog: [never_loop] Make sure to remove break in suggestions

@rustbot
Copy link
Collaborator

rustbot commented Jun 16, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 16, 2025
@profetia profetia force-pushed the issue15007 branch 3 times, most recently from 4f18d7f to 028a864 Compare June 17, 2025 13:17
@blyxyas
Copy link
Member

blyxyas commented Jul 11, 2025

Alexendoo's a little bit over the top on capacity (32 assigned PRs)
I'll shave off his last uncommented PRs.

r? @blyxyas

@rustbot rustbot assigned blyxyas and unassigned Alexendoo Jul 11, 2025
blyxyas
blyxyas requested changes Jul 14, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some starting review, mainly on readability.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jul 14, 2025
@profetia profetia requested a review from blyxyas July 15, 2025 13:43
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jul 15, 2025
@profetia
Copy link
Member Author

profetia commented Jul 15, 2025

Updated. Thank you!

blyxyas
blyxyas requested changes Jul 15, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be the last question, and I think this is ready!

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jul 15, 2025
@profetia
Copy link
Member Author

profetia commented Jul 16, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jul 16, 2025
@blyxyas blyxyas added this pull request to the merge queue Jul 20, 2025
Merged via the queue into rust-lang:master with commit 6543a09 Jul 20, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 20, 2025
@profetia profetia mentioned this pull request Jul 27, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 5, 2025
@blyxyas
Fix never_loop forget to remove break in nested loop (#15356)
828ee51 
Closes #15350

Follow up of #15064

changelog: [`never_loop`] add to remove `break` in nested loop
@profetia profetia deleted the issue15007 branch September 12, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

never_loop should also remove break labels that were inside the loop

4 participants

@profetia @rustbot @blyxyas @Alexendoo