Skip to content

clippy_dev refactor#14616

Merged
dswij merged 7 commits intorust-lang:masterfrom
Jarcho:dev_cleanup
May 14, 2025
Merged

clippy_dev refactor#14616
dswij merged 7 commits intorust-lang:masterfrom
Jarcho:dev_cleanup

Conversation

@Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 15, 2025 •
edited by rustbot
Loading

Based on #13223

Various refactoring on clippy_dev before upgrading rename and splitting clippy_lints into multiple crates.

Some improvements:

  • The working directory is set to the root clippy directory. Running from a subdirectory was kind of supported before sometimes. Now it just works.
  • File won't be written unless they're actually updated. Most of the time they weren't written, but a few cases slipped through.
  • Buffers are reused more for the negligible speed boost.

changelog: None

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 15, 2025
@rustbot

This comment has been minimized.

Sign in to view
This was referenced Apr 16, 2025
Merged
Merged
@samueltardieu
Copy link
Member

samueltardieu commented Apr 17, 2025

Since it's waiting on #13223 and I'll be AFK for a while, reassigning similarly to #13223
r? @flip1995

@rustbot rustbot assigned flip1995 and unassigned samueltardieu Apr 17, 2025
@Jarcho Jarcho force-pushed the dev_cleanup branch 3 times, most recently from f1cbd11 to 29fc393 Compare April 23, 2025 01:10
@Jarcho
Copy link
Contributor Author

Jarcho commented Apr 24, 2025

Since @flip1995 is busy r? clippy

@rustbot rustbot assigned dswij and unassigned flip1995 Apr 24, 2025
@rustbot

This comment has been minimized.

Sign in to view
dswij
dswij approved these changes May 11, 2025
View reviewed changes
Copy link
Member

@dswij dswij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs to resolve the conflict before merging @Jarcho

@samueltardieu
Copy link
Member

samueltardieu commented May 12, 2025

You'll have to rebase when #14784 is merged.

@Jarcho
Copy link
Contributor Author

Jarcho commented May 14, 2025

Ping @dswij in case github doesn't.

@dswij dswij added this pull request to the merge queue May 14, 2025
Merged via the queue into rust-lang:master with commit 40bead0 May 14, 2025
11 checks passed
github-merge-queue bot pushed a commit that referenced this pull request May 16, 2025
@samueltardieu
Extend cargo dev rename_lint (#14633)
604b7b0 
Based on #14616

Extends `rename_lint` to handle more cases and makes `update_lints` sort
`deprecated_lints.rs`.

changelog: None
github-merge-queue bot pushed a commit that referenced this pull request May 17, 2025
@samueltardieu
Refactor and speed up cargo dev fmt (#14638)
9ebfb84 
Based on #14616

`cargo dev fmt` should now run almost instantly rather than taking a few
seconds.

changelog: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Jarcho @rustbot @samueltardieu @dswij @flip1995