Skip to content

Install cmake to restore lintcheck runs#14514

Merged
Alexendoo merged 1 commit intorust-lang:masterfrom
samueltardieu:push-kzrzwyqlmutr
Apr 1, 2025
Merged

Install cmake to restore lintcheck runs#14514
Alexendoo merged 1 commit intorust-lang:masterfrom
samueltardieu:push-kzrzwyqlmutr

Conversation

@samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Apr 1, 2025 •
edited
Loading

tokio-rustls requires aws-lc-sys which requires cmake 3.x to be built. This installs cmake 3.x from the repository, overriding the cmake 4.x installation.

The situation will be reexamined in a few weeks, as aws-lc-sys will get a new release in a few days with cmake 4.x support. We will then be able to remove this temporary fix.

changelog: none
r? @ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 1, 2025
@samueltardieu samueltardieu force-pushed the push-kzrzwyqlmutr branch 3 times, most recently from 97a78f4 to 6392ebe Compare April 1, 2025 14:10
@samueltardieu samueltardieu changed the title Try removing cmake to restore lintcheck runs Install cmake to restore lintcheck runs Apr 1, 2025
@samueltardieu samueltardieu marked this pull request as ready for review April 1, 2025 14:22
@samueltardieu
Copy link
Member Author

samueltardieu commented Apr 1, 2025

r? @flip1995

@samueltardieu
Copy link
Member Author

samueltardieu commented Apr 1, 2025

This seems to be blocking #14490 and #14397, and probably all newer PRs.

flip1995
flip1995 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this is just an approval and merge. As lintcheck is not really in the common local developer flow, this shouldn't be noticable by most contributors

@samueltardieu
Copy link
Member Author

samueltardieu commented Apr 1, 2025

For me this is just an approval and merge. As lintcheck is not really in the common local developer flow, this shouldn't be noticable by most contributors

I've updated the description, and I've set a reminder on the second week of May to check if this fix can be removed.

@samueltardieu samueltardieu mentioned this pull request Apr 1, 2025
Merged
@Alexendoo Alexendoo added this pull request to the merge queue Apr 1, 2025
Merged via the queue into rust-lang:master with commit 227e43a Apr 1, 2025
17 checks passed
@samueltardieu
Copy link
Member Author

samueltardieu commented Apr 1, 2025 •
edited
Loading

Looks like this didn't help with #14397, while it did in the current PR, and the trace shows that cmake 3.x has been installed from packages.

@Alexendoo
Copy link
Member

Alexendoo commented Apr 1, 2025

Ah right, some runners are on different image versions it looks like and this PR happened to be on the slightly older one

In that case we should remove tokio-rustls from the lintcheck run for the time being

@samueltardieu samueltardieu mentioned this pull request Apr 1, 2025
Merged
@samueltardieu samueltardieu deleted the push-kzrzwyqlmutr branch April 1, 2025 18:01
@profetia profetia mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alexendoo Alexendoo Alexendoo approved these changes

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samueltardieu @Alexendoo @flip1995 @rustbot