r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Updated. Now these will also be covered.

This CI failure does not seem to be my problem. Any ideas?

This CI failure does not seem to be my problem. Any ideas?

I've restarted it to see if it's intermittent (we'll have to fix it anyway) or not. For reference, here is the failing version.

Edit: this does not look like it is intermittent.

Thanks to #14514, the CI is working now.

r? clippy

r? @samueltardieu

samueltardieu is on vacation.

Please choose another assignee.

r? Jarcho

sending it back, then 😄

For the util name something like has_non_owning_mutable_access would be a more precise as to what it's checking for.

I pushed a refactored version. The uitest passed but the compiler panicked in dogfood, can you maybe give me some help?

You'll need to keep track of what types have been seen as you recurse. Right now walking a type which recurses via PhantomData will overflow the stack. e.g.:

struct Foo<T> {
    inner: T,
    marker: core::marker::PhantomData<Self>,
}
impl<T: Iterator> Iterator for Foo<T> {
    type Item = T::Item;
    fn next(&mut self) -> Option<Self::Item> {
        self.inner.next()
    }
}

fn main() {
    Foo {
        inner: [].iter(),
        marker: core::marker::PhantomData,
    }.collect::<Vec<&i32>>().len();
}