Move clippy::module_name_repetitions to restriction (from pedantic)#13541
Move clippy::module_name_repetitions to restriction (from pedantic)#13541bors merged 1 commit intorust-lang:masterfrom
clippy::module_name_repetitions to restriction (from pedantic)#13541Conversation
…ic`) Rational: - Too pedantic IMO, it's often better to have fine grained modules and then rexport stuff instead of one gigantic file - STD doesn't do this either. Examples: - std::vec::Vec - std::collections::vec_deque::VecDequeue - rust-clippy#7666 commonly ignored
be744b7 to
8b075fc
Compare
blyxyas
left a comment
There was a problem hiding this comment.
I agree of the category change and approve, but just in case, is there any FCP-like process for moving lints between categories? I searched on Zulip and coulnd't find anything =^w^=
It's not documented, but the lint specifically allows this case, and only lints prefixes and suffixes: I don't mean to object to this change, only that this specific argument for it is not correct. |
There hasn't been one in the past. If you want you can create an FCP. I'd do that if I was unsure about such a change |
|
LGTM, thanks! ❤️ @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Rational:
#[warn(pedantic)]in my personal projects, but then always allow this lint. The fact that we had a few#[expect(clippy::module_name_repetitions)]also underlines this point IMOchangelog: Move [
module_name_repetitions] torestriction(frompedantic)#13541