Add `unused_enumerate_index` lint by dnbln · Pull Request #10404 · rust-lang/rust-clippy

dnbln · 2023-02-26T01:35:09Z

A lint for unused .enumerate() indexes (for (_, x) in iter.enumerate()).

I wasn't able to find a rustc_span::sym::Enumerate, so the code for checking that it's the correct Enumerate iterator is a bit weird.

changelog: New lint: [unused_enumerate_index]: A new lint for checking that the indexes from .enumerate() calls are used.
#10404

rustbot · 2023-02-26T01:35:13Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

bors · 2023-04-29T18:13:25Z

☔ The latest upstream changes (presumably #10647) made this pull request unmergeable. Please resolve the merge conflicts.

blyxyas · 2023-10-07T14:16:11Z

Hi @dnbln, Philipp doesn't have enough time to review PRs anymore, so I'll take the review from now on. Are you still interested in continuing with this development? ฅ^•ﻌ•^ฅ

r? @blyxyas

dnbln · 2023-10-09T17:29:31Z

Hi @blyxyas, yes, certainly. I have resolved the merge conflicts; do let me know if there's anything else I should do.

blyxyas

Just a first review. Very good for a first review, and welcome to contributing to Clippy! ❤️

clippy_lints/src/loops/mod.rs

clippy_lints/src/loops/unused_enumerate_index.rs

blyxyas

I did a little bit of trolling in my last review hehe :3
Seems pretty good, this is the last review before doing the final complete one.

clippy_lints/src/loops/unused_enumerate_index.rs

clippy_lints/src/loops/mod.rs

blyxyas

Just some more tests and this is it! Thanks for your patience and I hope this new lint (quite a useful one, also) gets merged as soon as possible! ❤️ ^•ﻌ•^ฅ♡

tests/ui/unused_enumerate_index.rs

clippy_lints/src/loops/unused_enumerate_index.rs

blyxyas · 2023-10-22T12:38:37Z

We have a slight block here (don't worry, I'll fix it soon（=´∇｀=）). We have this deprecated paths module, and yesterday I started an effort to convert these paths to diagnostic items and convert existing uses of these paths to use diagnostic items.

It won't take long. I'll update you with time.
There isn't anything more to do on your end.

blyxyas · 2023-10-26T17:58:56Z

It seems like it will take more than expected (without even counting the reviewing + sync time), so I'll unblock this PR and just fix it later in my rust-lang/rust branch. I don't think it's worth it making you wait even longer haha 😅

blyxyas

Ok, that's it! Add a test implementing std::iter::Iterator for a Dummy3 structure and then squash the branch into 1 or 2 commits. It should be merge-ready then!

blyxyas · 2023-10-30T23:06:02Z

clippy_lints/src/loops/unused_enumerate_index.rs

+fn pat_is_wild<'tcx>(cx: &LateContext<'tcx>, pat: &'tcx PatKind<'_>, body: &'tcx Expr<'_>) -> bool {
+    match *pat {
+        PatKind::Wild => true,
+        PatKind::Binding(_, id, ident, None) if ident.as_str().starts_with('_') => !is_local_used(cx, body, id),


Pretty smart move.

I've used the FOR_KV_MAP lint for reference, this function is taken straight from there. Maybe it could be moved to an util function, since with this it would already be defined 3 times?

rust-clippy/clippy_lints/src/loops/for_kv_map.rs

Lines 59 to 66 in 7d34406

/// Returns `true` if the pattern is a `PatWild` or an ident prefixed with `_`.

fn pat_is_wild<'tcx>(cx: &LateContext<'tcx>, pat: &'tcx PatKind<'_>, body: &'tcx Expr<'_>) -> bool {

match *pat {

PatKind::Wild => true,

PatKind::Binding(_, id, ident, None) if ident.as_str().starts_with('_') => !is_local_used(cx, body, id),

_ => false,

}

}

Oh yes then, move to it clippy_utils

tests/ui/unused_enumerate_index.rs

Co-authored-by: Alejandra González <blyxyas@gmail.com>

This function was previously defined for the iter_kv_map, for_kw_map, and unused_enumerate_index lints. This commit extracts it into clippy_utils.

blyxyas

LGTM, thanks for the lint, and sorry for taking so long to review! ❤️

blyxyas · 2023-11-01T15:21:59Z

@bors r+

bors · 2023-11-01T15:22:02Z

📌 Commit bb9cc6d has been approved by blyxyas

It is now in the queue for this repository.

bors · 2023-11-01T15:52:58Z

⌛ Testing commit bb9cc6d with merge 919f698...

bors · 2023-11-01T16:02:56Z

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 919f698 to master...

rustbot assigned flip1995 Feb 26, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 26, 2023

rustbot assigned blyxyas and unassigned flip1995 Oct 7, 2023

dnbln force-pushed the feat/unused_enumerate_index branch from a4c8c15 to 06454c8 Compare October 9, 2023 17:28

blyxyas requested changes Oct 10, 2023

View reviewed changes

blyxyas reviewed Oct 14, 2023

View reviewed changes

clippy_lints/src/loops/unused_enumerate_index.rs Outdated Show resolved Hide resolved

clippy_lints/src/loops/mod.rs Outdated Show resolved Hide resolved

clippy_lints/src/loops/mod.rs Outdated Show resolved Hide resolved

blyxyas reviewed Oct 18, 2023

View reviewed changes

tests/ui/unused_enumerate_index.rs Show resolved Hide resolved

dnbln commented Oct 20, 2023

View reviewed changes

clippy_lints/src/loops/unused_enumerate_index.rs Outdated Show resolved Hide resolved

dnbln commented Oct 20, 2023

View reviewed changes

clippy_lints/src/loops/unused_enumerate_index.rs Show resolved Hide resolved

blyxyas added the hacktoberfest-accepted label Oct 30, 2023

blyxyas approved these changes Oct 30, 2023

View reviewed changes

feat: unused_enumerate_index lint

0b90f72

dnbln force-pushed the feat/unused_enumerate_index branch from 56f315a to 98f0c2c Compare October 31, 2023 16:53

Apply suggestions from code review

14b8290

Co-authored-by: Alejandra González <blyxyas@gmail.com>

dnbln force-pushed the feat/unused_enumerate_index branch from 98f0c2c to 14b8290 Compare October 31, 2023 17:22

refactor: extract common pat_is_wild to clippy_utils

bb9cc6d

This function was previously defined for the iter_kv_map, for_kw_map, and unused_enumerate_index lints. This commit extracts it into clippy_utils.

dnbln force-pushed the feat/unused_enumerate_index branch from f209845 to bb9cc6d Compare November 1, 2023 13:19

blyxyas approved these changes Nov 1, 2023

View reviewed changes

bors merged commit 919f698 into rust-lang:master Nov 1, 2023

blyxyas removed the hacktoberfest-accepted label Jan 29, 2024

	/// Returns `true` if the pattern is a `PatWild` or an ident prefixed with `_`.
	fn pat_is_wild<'tcx>(cx: &LateContext<'tcx>, pat: &'tcx PatKind<'_>, body: &'tcx Expr<'_>) -> bool {
	match *pat {
	PatKind::Wild => true,
	PatKind::Binding(_, id, ident, None) if ident.as_str().starts_with('_') => !is_local_used(cx, body, id),
	_ => false,
	}
	}

Conversation

dnbln commented Feb 26, 2023 • edited by xFrednet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 26, 2023

Uh oh!

bors commented Apr 29, 2023

Uh oh!

blyxyas commented Oct 7, 2023

Uh oh!

dnbln commented Oct 9, 2023

Uh oh!

blyxyas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blyxyas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blyxyas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blyxyas commented Oct 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blyxyas commented Oct 26, 2023

Uh oh!

blyxyas left a comment

Choose a reason for hiding this comment

Uh oh!

blyxyas Oct 30, 2023

Choose a reason for hiding this comment

Uh oh!

dnbln Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

blyxyas Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

blyxyas left a comment

Choose a reason for hiding this comment

Uh oh!

blyxyas commented Nov 1, 2023

Uh oh!

bors commented Nov 1, 2023

Uh oh!

bors commented Nov 1, 2023

Uh oh!

bors commented Nov 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dnbln commented Feb 26, 2023 •

edited by xFrednet

Loading

blyxyas commented Oct 22, 2023 •

edited

Loading