Stabilize macro_vis_matcher#1096
Merged
frewsxcv merged 1 commit intorust-lang:masterfrom Aug 22, 2018
Merged
Conversation
3 tasks
frewsxcv
approved these changes
Aug 17, 2018
Contributor
frewsxcv
left a comment
There was a problem hiding this comment.
LGTM! I think we should wait for the Rust PR to get approved before merging?
Contributor
Author
|
I think so, although this is my first time contributing, so not sure what the protocol is :) |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 21, 2018
…her, r=cramertj Stabilize macro_vis_matcher This PR should stabilize [macro_vis_matcher](rust-lang#41022) feature. - [ ] "reference" book changes: rust-lang/reference#400 - [ ] "Rust by example" book changes: rust-lang/rust-by-example#1096 - [ ] "clippy" changes: rust-lang/rust-clippy#3055 r? @cramertj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @cramertj