Warning

• These commits modify unsafe code. Please review it carefully!

r? @emilio

(I am very likely doing something wrong, I saw these presubmit failures on #1990 and I figured fixing them in a separate PR is the right thing to do, but I mostly have no clue so beware :)

What clang version are you using?

Ahh, I see what's going on here, and I think it's the same that @adetaylor was seeing recently on mac. I think whatever clang you're using is confusing our version detection. Your expectations (like tests/expectations/tests/issue-643-inner-struct.rs) are the ones expected on modern libclang (tests/expectations/tests/libclang-9/issue-643-inner-struct.rs), so somehow the clang_version() call in tests/tests is failing to detect a version, and we're guessing "ancient".

Two fixes, one short term and one long term. Short term fix would be something like #1993. Better fix is figuring out what your clang claims to be and what it really is, and fix the version parsing code.

Thanks for the pointer! I've uploaded #1996 with the parsing fix. I believe this PR can be closed now. Thank you!