Skip to content

fix: Fix trait impl completions not triggering after fn/const/type#11967

Merged
bors[bot] merged 1 commit intorust-lang:masterfrom
jonas-schievink:fix-impl-completion-lookup-by
Apr 12, 2022
Merged

fix: Fix trait impl completions not triggering after fn/const/type#11967
bors[bot] merged 1 commit intorust-lang:masterfrom
jonas-schievink:fix-impl-completion-lookup-by

Conversation

@jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Apr 12, 2022

screenshot-2022-04-12-17:13:01

Fixes #11467
cc #11860

bors r+

bors bot added a commit that referenced this pull request Apr 12, 2022
11967: fix: Fix trait impl completions not triggering after `fn`/`const`/`type` r=jonas-schievink a=jonas-schievink

![screenshot-2022-04-12-17:13:01](https://user-images.githubusercontent.com/1786438/162996087-56540f5e-a6be-4111-a4a5-8de21f483a5e.png)

Fixes #11467
cc #11860

bors r+

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
@bors
Copy link
Contributor

bors bot commented Apr 12, 2022

Timed out.

@lnicola
Copy link
Member

lnicola commented Apr 12, 2022

bors retry

@bors
Copy link
Contributor

bors bot commented Apr 12, 2022

@bors bors bot merged commit a64a70e into rust-lang:master Apr 12, 2022
@jonas-schievink jonas-schievink deleted the fix-impl-completion-lookup-by branch April 12, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: Code completion when implementing functions in VSCode doesn't work properly.

2 participants