Clone the src/llvm-project submodule if profiling is enabled#99872
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 29, 2022
Merged
Clone the src/llvm-project submodule if profiling is enabled#99872bors merged 1 commit intorust-lang:masterfrom
src/llvm-project submodule if profiling is enabled#99872bors merged 1 commit intorust-lang:masterfrom
Conversation
To compile rustc with profiling information, `compiler-rt` from LLVM is required. Building it requires the `src/llvm-project` submodule to be initialized and updated.
Contributor
|
r? @jyn514 (rust-highfive has picked a reviewer for you, use r? to override) |
Member
|
👍 this is what I imagined. Have you tested to make sure it works? You can get rid of the submodule with |
Member
Author
|
Yes, I have tested it locally. I deinited the submodule, and then built it without profiling info. The submodule did not get cloned. I then enabled profiling, and it got cloned and compiled |
Member
|
@bors r+ rollup (CI doesn't use submodules) |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#99686 (add suggestion when there is a impl of external trait on pointer with wrong coherence rules) - rust-lang#99760 (doc/rustc: describe the uefi target platforms) - rust-lang#99766 (Htmldocck: Substitute the doc channel when blessing) - rust-lang#99781 (Use String::from_utf8_lossy in CStr demo) - rust-lang#99803 (Update mentions to `rustc_metadata::rmeta::Lazy`) - rust-lang#99845 (Remove `$` prefix for bash scripts in doc) - rust-lang#99850 (rustdoc: Remove more Clean trait implementations) - rust-lang#99872 (Clone the `src/llvm-project` submodule if profiling is enabled) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To compile rustc with profiling information,
compiler-rtfrom LLVM is required. Building it requires thesrc/llvm-projectsubmodule to be initialized and updated.Fixes #99869