Remove duplicate notes from error on inter-crate ambiguous impl of traits#99095
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 11, 2022
Merged
Remove duplicate notes from error on inter-crate ambiguous impl of traits#99095bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
Contributor
|
The change looks good! Can you move the UI test somewhere different than |
Contributor
Author
|
@compiler-errors Thank you for taking a look. I moved test to |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@compiler-errors CI passed and I confirmed all UI tests passed on my local machine. Would you review this patch again? |
Contributor
|
This looks good to me. It's typically better to add new unit tests to subdirectories of |
Contributor
Author
|
Thanks for your advice. I moved the test case again. |
Contributor
|
Thanks! @bors r+ |
Collaborator
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 10, 2022
Remove duplicate notes from error on inter-crate ambiguous impl of traits Fixes rust-lang#99092
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 10, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#98713 (promote placeholder bounds to 'static obligations) - rust-lang#99094 (Remove extra space in AtomicPtr::new docs) - rust-lang#99095 (Remove duplicate notes from error on inter-crate ambiguous impl of traits) - rust-lang#99114 (Group .test-arrow CSS rules and fix rgb/rgba property) - rust-lang#99128 (Fix `download-ci-llvm` NixOS patching for binaries) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99092