Merged
Conversation
jyn514
approved these changes
Jul 8, 2022
5042ee8 to
5b46b45
Compare
Member
Author
|
Updated. |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Strange that it doesn't find the pattern. I'll check what I did wrong. |
8353eba to
53edb1e
Compare
Member
Author
|
I needed to add a new check ( |
Member
|
I don't think we should add regex support for compiletest just for this. You can use a different pattern for error-pattern instead, |
Member
Author
|
I thought the idea was to confirm that we had |
Member
|
Hmm, fair enough. cc @Mark-Simulacrum just in case you happen to have strong opinions about adding a regex matcher to the UI test runner, but this seems fine to me. @bors r+ |
Collaborator
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 10, 2022
…, r=jyn514 Fix rustdoc help options Fixes rust-lang#98976. Since you're the one who found out about the problem and also provided the solution (thanks for both!): r? `@jyn514`
Member
|
@bors r- |
Member
|
@bors rollup=never |
53edb1e to
b65d3a6
Compare
Member
Author
|
Updated the UI output. @bors r=jyn514 |
Collaborator
Member
|
@bors rollup=iffy |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 11, 2022
…, r=jyn514 Fix rustdoc help options Fixes rust-lang#98976. Since you're the one who found out about the problem and also provided the solution (thanks for both!): r? `@jyn514`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 11, 2022
…, r=jyn514 Fix rustdoc help options Fixes rust-lang#98976. Since you're the one who found out about the problem and also provided the solution (thanks for both!): r? ``@jyn514``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 12, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#97210 (Support `-A`, `-W`, `-D` and `-F` when running `./x.py clippy`) - rust-lang#99055 (Fix rustdoc help options) - rust-lang#99075 (Fix duplicated type annotation suggestion) - rust-lang#99124 (Fix sized check ICE in asm check) - rust-lang#99142 (fix(doctest): treat fatal parse errors as incomplete attributes) - rust-lang#99145 (Don't rerun the build script for the compiler each time on non-windows platforms) - rust-lang#99146 (Do not error during method probe on `Sized` predicates for types that aren't the method receiver) - rust-lang#99161 (compiletest: trim edition before passing as flag) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 12, 2022
…x, r=Dylan-DPC Put back UI test regex I just realized I overwrote these two commits in rust-lang#99055 when force pushing to fix the stdout output... r? `@Dylan-DPC`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98976.
Since you're the one who found out about the problem and also provided the solution (thanks for both!):
r? @jyn514