Remove "sys isn't exported yet" phrase#97499
Merged
bors merged 1 commit intorust-lang:masterfrom May 30, 2022
Merged
Conversation
Contributor
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Contributor
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit eebf7cb8ba57840343adb4f207a0fa482c31432d has been approved by |
Collaborator
|
⌛ Testing commit eebf7cb8ba57840343adb4f207a0fa482c31432d with merge 14691fdbc927adce9e7fdbfb5302385568042c99... |
Collaborator
|
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
The oldest occurence is from 9e224c2, which is from the pre-1.0 days. In the years since then, std::sys still hasn't been exported, and the last attempt was met with strong criticism: rust-lang#97151 Thus, removing the "yet" part makes a lot of sense.
Member
|
@bors r+ |
Collaborator
|
📌 Commit 6d63d3b has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#97494 (Use Box::new() instead of box syntax in library tests) - rust-lang#97499 (Remove "sys isn't exported yet" phrase) - rust-lang#97504 (Ensure source file present when calculating max line number) - rust-lang#97519 (Re-add help_on_error for download-ci-llvm) - rust-lang#97531 (Note pattern mismatch coming from `for` loop desugaring) - rust-lang#97545 (Reword safety comments in core/hash/sip.rs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The oldest occurence is from 9e224c2,
which is from the pre-1.0 days. In the years since then, std::sys still
hasn't been exported, and the last attempt was met with strong criticism:
#97151
Thus, removing the "yet" part makes a lot of sense.