Remove unnecessay .report() on ExitCode#97170
Merged
bors merged 1 commit intorust-lang:masterfrom May 20, 2022
Merged
Conversation
Contributor
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. |
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 7013dc5 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#96539 (Add release notes for 1.61.0) - rust-lang#97142 (move processing of `source_scope_data` into `MutVisitor`'s impl of `Integrator` when inline) - rust-lang#97155 (Fix doc typo) - rust-lang#97169 (Improve `u32 as char` cast diagnostic) - rust-lang#97170 (Remove unnecessay .report() on ExitCode) - rust-lang#97171 (Add regression test for rust-lang#88119) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #93442, the return type is
ExitCodeanyway so there's no need to do a conversion using.report()(which is now just a no-op).