Skip to content

Revert "Implement [OsStr]::join", which was merged without FCP.#96841

Merged
bors merged 1 commit intorust-lang:masterfrom
thomcc:revert-osstr-join
May 9, 2022
Merged

Revert "Implement [OsStr]::join", which was merged without FCP.#96841
bors merged 1 commit intorust-lang:masterfrom
thomcc:revert-osstr-join

Conversation

@thomcc
Copy link
Member

@thomcc thomcc commented May 8, 2022

This reverts commit 4fcbc53, see #96744. (I'm terribly sorry, and truly don't remember r+ing it, or even having seen it before yesterday, which is... genuinely very worrisome for me).

r? @m-ou-se

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 8, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented May 8, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2022
@m-ou-se
Copy link
Member

m-ou-se commented May 8, 2022

I'm terribly sorry, and truly don't remember r+ing it, or even having seen it before yesterday, which is... genuinely very worrisome for me

No worries. I've done the same a while ago where I gave a bot command on the wrong PR. It happens. :)

@bors r+

@bors
Copy link
Collaborator

bors commented May 8, 2022

📌 Commit df446cb has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2022
@m-ou-se m-ou-se added this to the 1.62.0 milestone May 9, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request May 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2022
@bors
Auto merge of rust-lang#96877 - matthiaskrgr:rollup-evlh6ot, r=matthi…
0dd7e10 
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#95483 (Improve floating point documentation)
 - rust-lang#96008 (Warn on unused `#[doc(hidden)]` attributes on trait impl items)
 - rust-lang#96841 (Revert "Implement [OsStr]::join", which was merged without FCP.)
 - rust-lang#96844 (Actually fix ICE from rust-lang#96583)
 - rust-lang#96854 (Some subst cleanup)
 - rust-lang#96858 (Remove unused param from search.js::checkPath)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f4bef2e into rust-lang:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@m-ou-se m-ou-se

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.62.0

Development

Successfully merging this pull request may close these issues.

5 participants

@thomcc @rust-highfive @m-ou-se @bors @rustbot