Mention traits and types involved in unstable trait upcasting#96378
Merged
bors merged 1 commit intorust-lang:masterfrom May 18, 2022
Merged
Mention traits and types involved in unstable trait upcasting#96378bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
marmeladema
reviewed
Apr 25, 2022
Contributor
There was a problem hiding this comment.
Is this file supposed to be deleted?
Contributor
Author
There was a problem hiding this comment.
No, but it keeps showing up every time I make a new PR. I'll revert it...
Contributor
There was a problem hiding this comment.
I asked because I had the same problem locally and I could not understand why
Contributor
Author
There was a problem hiding this comment.
I think it might've just been a file that got deleted but the change never made it to master. It's probably happening for everyone 👀
Member
|
This is nice. r=me after a rebase. |
986e350 to
0de7568
Compare
Contributor
Author
|
@bors r=nagisa |
Collaborator
|
📌 Commit 0de7568 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#94639 (Suggest dereferencing non-lval mutable reference on assignment) - rust-lang#95979 (update coherence docs, fix generator + opaque type ICE) - rust-lang#96378 (Mention traits and types involved in unstable trait upcasting) - rust-lang#96917 (Make HashMap fall back to RtlGenRandom if BCryptGenRandom fails) - rust-lang#97101 (Add tracking issue for ExitCode::exit_process) - rust-lang#97123 (Clean fix for rust-lang#96223) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95972 by printing the traits being upcasted and the types being coerced that cause that upcasting...
the poor span mentioned in the original issue has nothing to do with trait upcasting diagnostic here...
I don't think I can solve that issue in general without fixing the ObligationCauseCode and span that gets passed into Coerce.