remove_dir_all_recursive: treat ELOOP the same as ENOTDIR#96234
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 20, 2022
Merged
remove_dir_all_recursive: treat ELOOP the same as ENOTDIR#96234bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Contributor
|
r? @thomcc (rust-highfive has picked a reviewer for you, use r? to override) |
Member
|
According to https://man7.org/linux/man-pages/man2/open.2.html, @bors r+ |
Collaborator
|
📌 Commit cff3f1e has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 20, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#93313 (Check if call return type is visibly uninhabited when building MIR) - rust-lang#96160 (Miri/interpreter debugging tweaks) - rust-lang#96167 (Replace sys/unix/weak AtomicUsize with AtomicPtr) - rust-lang#96168 (Improve AddrParseError description) - rust-lang#96206 (Use sys::unix::locks::futex* on wasm+atomics.) - rust-lang#96234 (remove_dir_all_recursive: treat ELOOP the same as ENOTDIR) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
hkratz
added a commit
to rusticstuff/rust
that referenced
this pull request
Jun 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On older Linux kernels (I tested on 4.4, corresponding to Ubuntu 16.04), opening a symlink using
O_DIRECTORY | O_NOFOLLOWreturnsELOOPinstead ofENOTDIR. We should handle it the same, since a symlink is still not a directory and needs to beunlinked.