Don't declare test_variadic_fnptr with two conflicting signatures#95088
Don't declare test_variadic_fnptr with two conflicting signatures#95088bors merged 2 commits intorust-lang:masterfrom
Conversation
|
Some changes occured to rustc_codegen_cranelift cc @bjorn3 |
|
r? @scottmcm (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
ccd16da to
0467300
Compare
|
@bors r+ |
|
📌 Commit 0467300 has been approved by |
…tolnay Don't declare test_variadic_fnptr with two conflicting signatures It is UB for LLVM and results in a compile error for Cranelift. cc https://github.com/bjorn3/rustc_codegen_cranelift/issues/806 Fixes rust-lang#66690
…tolnay Don't declare test_variadic_fnptr with two conflicting signatures It is UB for LLVM and results in a compile error for Cranelift. cc https://github.com/bjorn3/rustc_codegen_cranelift/issues/806 Fixes rust-lang#66690
|
Looks like this causes linking failures on windows: |
|
I hoped that printf would be available on msvc. I think I will need to look for another symbol that is. |
|
According to https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/printf-printf-l-wprintf-wprintf-l?view=msvc-170 printf should be available. @dtolnay do you have any clue what the issue could be? And if not would it be fine to disable the test on windows? |
|
☔ The latest upstream changes (presumably #95142) made this pull request unmergeable. Please resolve the merge conflicts. |
It is UB for LLVM and results in a compile error for Cranelift
0467300 to
56939ff
Compare
|
(rebased, but haven't fixed it yet) |
dtolnay
left a comment
There was a problem hiding this comment.
Don't know. I'd just exclude this test on Windows too.
|
Done |
|
@bors r+ |
|
📌 Commit 4af755b has been approved by |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (2b50739): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
It is UB for LLVM and results in a compile error for Cranelift.
cc https://github.com/bjorn3/rustc_codegen_cranelift/issues/806
Fixes #66690