Merged
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon. Please see the contribution instructions for more information. |
Member
|
r? @Dylan-DPC |
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit eb2b944 has been approved by |
WaffleLapkin
reviewed
Mar 1, 2022
Member
WaffleLapkin
left a comment
There was a problem hiding this comment.
I think I've spotted some typos nearby your fixes :')
| // Error if `?Trait` bounds in where clauses don't refer directly to type paramters. | ||
| // Error if `?Trait` bounds in where clauses don't refer directly to type parameters. | ||
| // Note: we used to clone these bounds directly onto the type parameter (and avoid lowering | ||
| // these into hir when we lower thee where clauses), but this makes it quite difficult to |
Member
There was a problem hiding this comment.
Suggested change
| // these into hir when we lower thee where clauses), but this makes it quite difficult to | |
| // these into hir when we lower the where clauses), but this makes it quite difficult to |
| @@ -1992,7 +1992,7 @@ impl<'tcx> RegionInferenceContext<'tcx> { | |||
| .find_map(|constraint| { | |||
| if let ConstraintCategory::Predicate(predicate_span) = constraint.category { | |||
| // We currentl'y doesn't store the `DefId` in the `ConstraintCategory` | |||
Member
There was a problem hiding this comment.
Suggested change
| // We currentl'y doesn't store the `DefId` in the `ConstraintCategory` | |
| // We currently don't store the `DefId` in the `ConstraintCategory` |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 1, 2022
compiler: fix some typos
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 1, 2022
compiler: fix some typos
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 2, 2022
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#94464 (Suggest adding a new lifetime parameter when two elided lifetimes should match up for traits and impls.) - rust-lang#94476 (7 - Make more use of `let_chains`) - rust-lang#94478 (Fix panic when handling intra doc links generated from macro) - rust-lang#94482 (compiler: fix some typos) - rust-lang#94490 (Update books) - rust-lang#94496 (tests: accept llvm intrinsic in align-checking test) - rust-lang#94498 (9 - Make more use of `let_chains`) - rust-lang#94503 (Provide C FFI types via core::ffi, not just in std) - rust-lang#94513 (update Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.