Improve docs for is_running to explain use case#94033
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 21, 2022
Merged
Conversation
Contributor
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
8 tasks
m-ou-se
reviewed
Feb 16, 2022
m-ou-se
reviewed
Feb 16, 2022
library/std/src/thread/mod.rs
Outdated
Comment on lines
1455
to
1456
Member
There was a problem hiding this comment.
Just a thought: we could 'fix' this by just always pthread_detaching every spawned thread directly, and only using our own return value Arc for 'join'ing threads. (This is also how I implemented scoped threads.) Then we can make sure that join will instantly return with no possibility of blocking as soon as the Arc is ready.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
Rename JoinHandle::is_running to is_finished. This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment) Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
Rename JoinHandle::is_running to is_finished. This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment) Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
Rename JoinHandle::is_running to is_finished. This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment) Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
Rename JoinHandle::is_running to is_finished. This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment) Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
Rename JoinHandle::is_running to is_finished. This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment) Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
Rename JoinHandle::is_running to is_finished. This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment) Taking some of the docs suggestions from rust-lang#94033
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 4, 2022
Rename JoinHandle::is_running to is_finished. This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment) Taking some of the docs suggestions from rust-lang#94033
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 4, 2022
Rename JoinHandle::is_running to is_finished. This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment) Taking some of the docs suggestions from rust-lang#94033
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
Rename JoinHandle::is_running to is_finished. This is renaming `is_running` to `is_finished` as discussed on the tracking issue here: rust-lang#90470 (comment) Taking some of the docs suggestions from rust-lang#94033
Collaborator
|
☔ The latest upstream changes (presumably #94612) made this pull request unmergeable. Please resolve the merge conflicts. |
is_running to explain use case and discourage busy-polllingis_running to explain use case and discourage busy-polling
06bddb5 to
7098a71
Compare
is_running to explain use case and discourage busy-pollingis_running to explain use case
Member
Author
|
I've rebased this to eliminate the merge conflicts. I think there's value in explaining the use case for this, to go along with the now-present explanation of when to use @rustbot ready |
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 7098a71 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 21, 2022
Rollup of 11 pull requests Successful merges: - rust-lang#94033 (Improve docs for `is_running` to explain use case) - rust-lang#97269 (adjust transmute const stabilization version) - rust-lang#97805 (Add proper tracing spans to rustc_trait_selection::traits::error_reporting) - rust-lang#98022 (Fix erroneous span for borrowck error) - rust-lang#98124 (Improve loading of crates.js and sidebar-items.js) - rust-lang#98278 (Some token stream cleanups) - rust-lang#98306 (`try_fold_unevaluated` for infallible folders) - rust-lang#98313 (Remove lies in comments.) - rust-lang#98323 (:arrow_up: rust-analyzer) - rust-lang#98329 (Avoid an ICE and instead let the compiler report a useful error) - rust-lang#98330 (update ioslice docs to use shared slices) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.