Don't relabel to a team if there is already a team label#93944
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 13, 2022
Merged
Don't relabel to a team if there is already a team label#93944bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Member
|
I'll go ahead and merge, but it's likely that in the long run the fix here might involve writing into triagebot's database which files were edited or something like that, and then not triggering on further edits of those files. But that needs more work to get the design right, this seems ok for now as a first step. (Alternatively, we could move further away from the usage of T- labels, which to me seem relatively unclear in intent or at least multiuse today and for somewhat conflicting uses). @bors r+ rollup |
Collaborator
|
📌 Commit a0d603f has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2022
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#89926 (make `Instant::{duration_since, elapsed, sub}` saturating and remove workarounds) - rust-lang#90532 (More informative error message for E0015) - rust-lang#93810 (Improve chalk integration) - rust-lang#93851 (More practical examples for `Option::and_then` & `Result::and_then`) - rust-lang#93885 (bootstrap.py: Suggest disabling download-ci-llvm option if url fails to download) - rust-lang#93886 (Stabilise inherent_ascii_escape (FCP in rust-lang#77174)) - rust-lang#93930 (add link to format_args! when mention it in docs) - rust-lang#93936 (Couple of driver cleanups) - rust-lang#93944 (Don't relabel to a team if there is already a team label) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should prevent cases like #93628, where teams have been manually assigned, but changes are pushed. We give up adding new labels on new changes; but I feel like that is less frequent.
r? @Mark-Simulacrum