Closed
Conversation
This option is controls when LLVM build adds `-fno-rtti`. Some details available here: https://www.llvm.org/docs/HowToSetUpLLVMStyleRTTI.html When this option is enabled, llvm build produces a bit more symbols: ```` rust % nm build/x86_64-apple-darwin/llvm/lib/libLLVMCore.a | grep llvm10CallbackVHE 0000000000007120 S __ZTIN4llvm10CallbackVHE 0000000000007240 S __ZTSN4llvm10CallbackVHE 00000000000070e8 S __ZTVN4llvm10CallbackVHE ```` and just to compare the same build without this option (current behaviour): ``` rust % nm build/x86_64-apple-darwin/llvm/lib/libLLVMCore.a | grep llvm10CallbackVHE 00000000000070b8 S __ZTVN4llvm10CallbackVHE ``` An attempt to bootstrap `rust` with `clang` which was built with enabled RTTI may fail with linking error like: ``` = note: dyld: Symbol not found: __ZTIN4llvm10CallbackVHE Referenced from: /opt/local/libexec/llvm-9.0/bin/../lib/libclang-cpp.dylib Expected in: .../build/x86_64-apple-darwin/stage2/lib/libLLVM.dylib in /opt/local/libexec/llvm-9.0/bin/../lib/libclang-cpp.dylib ```
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
11 tasks
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 4, 2022
The better approach is backported to upstream as rust-lang/rust#93640
Member
|
What is the exact purpose of this option? Why would someone want to enable it? |
Author
|
@bjorn3 I've tried to build rustc by clang which was compiled without As soon as I added this option and enabled it to this build => it linked and works. |
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 4, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 5, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 5, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 5, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 5, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 5, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 5, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 5, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 5, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 5, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 5, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 5, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 6, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 6, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 6, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 6, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 6, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 7, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 7, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 7, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 8, 2022
The better approach is backported to upstream as rust-lang/rust#93640
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 8, 2022
The better approach is backported to upstream as rust-lang/rust#93640
Member
|
I'm going to close this in favor of #93756. Thanks! |
catap
added a commit
to catap/rust-legacy-bootstrap
that referenced
this pull request
Feb 13, 2022
The better approach is backported to upstream as rust-lang/rust#93640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option is controls when LLVM build adds
-fno-rtti. Some details available here: https://www.llvm.org/docs/HowToSetUpLLVMStyleRTTI.htmlWhen this option is enabled, llvm build produces a bit more symbols:
and just to compare the same build without this option (current behaviour):
An attempt to bootstrap
rustwithclangwhich was built with enabled RTTI may fail with linking error like: