rustdoc: Add missing dot separator#92937
Conversation
jsha
left a comment
There was a problem hiding this comment.
Thanks for fixing! I was just about to start working on this.
| // @has - '//div[@id="implementors-list"]//*[@class="rightside"]' '4.0 · source' | ||
|
|
||
| // @has foo/struct.Foo.html | ||
| // @has - '//div[@class="main-heading"]/*[@class="out-of-band"]' '1.0· source · ' |
There was a problem hiding this comment.
There's a missing space here.
| // @has - '//div[@class="main-heading"]/*[@class="out-of-band"]' '1.0· source · ' | |
| // @has - '//div[@class="main-heading"]/*[@class="out-of-band"]' '1.0 · source · ' |
There was a problem hiding this comment.
No, there isn't (otherwise the test would fail). :)
There was a problem hiding this comment.
With an image you'll understand better what's happening:
There was a problem hiding this comment.
Ah, got it. It looks like there's a missing-space problem in the templates, but it's papered over by padding. I'll fix in a followup PR.
| #![feature(staged_api)] | ||
|
|
||
| // @has foo/trait.Bar.html | ||
| // @has - '//div[@class="main-heading"]/*[@class="out-of-band"]' '1.0· source · ' |
There was a problem hiding this comment.
There's a missing space here.
| // @has - '//div[@class="main-heading"]/*[@class="out-of-band"]' '1.0· source · ' | |
| // @has - '//div[@class="main-heading"]/*[@class="out-of-band"]' '1.0· source · ' |
There was a problem hiding this comment.
@jsha I think you forgot to add the space in your suggestion.
There was a problem hiding this comment.
Same answer as above.
|
By the way, do we need to worry about the case where there's no source available? I think not because the version numbers are only shown in the stdlib. |
|
That is a very good point. I'll open an issue in case |
|
@bors r+ rollup |
|
📌 Commit 75967ce has been approved by |
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#92795 (Link sidebar "location" heading to top of page) - rust-lang#92799 (Remove some unnecessary uses of `FieldDef::ident`) - rust-lang#92808 (Fix `try wrapping expression in variant` suggestion with struct field shorthand) - rust-lang#92819 (rustdoc: remove hand-rolled isatty) - rust-lang#92876 (Fix suggesting turbofish with lifetime arguments) - rust-lang#92921 (Rename Printer constructor from mk_printer() to Printer::new()) - rust-lang#92937 (rustdoc: Add missing dot separator) - rust-lang#92953 (Copy an example to PartialOrd as well) - rust-lang#92977 (Docs: recommend VecDeque instead of Vec::remove(0)) - rust-lang#92981 (fix const_ptr_offset_from tracking issue) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #92901.
r? @jsha