Move generator check earlier in inlining.#91975
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 18, 2021
Merged
Conversation
Contributor
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
tmiasko
approved these changes
Dec 15, 2021
Member
|
@bors r+ |
Collaborator
|
📌 Commit d48dbdc has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#87901 (Fix suggestion of additional `pub` when using `pub pub fn ...`) - rust-lang#89090 (Lint bare traits in AstConv.) - rust-lang#91818 (Show the unused type for `unused_results` lint) - rust-lang#91910 (miri: lift restriction on extern types being the only field in a struct) - rust-lang#91928 (Constify (most) `Option` methods) - rust-lang#91975 (Move generator check earlier in inlining.) - rust-lang#92016 (builtin_macros: allow external consumers for AsmArgs parsing) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inlining into generator may create references to other generators. For instance, inlining
Pin::<&mut from_generator::GenFuture<[generator1]>>::new_uncheckedintogenerator2. This cross reference can then create cycles when computing inlining forgenerator1.In order to avoid this kind of surprises, we forbid all inlining into generators, and rely on LLVM to do the right thing. The existing
remove-zst-query-cyclealready ICEs in inline-mir mode, so we use it as test.Split from #91743.