Remove in_band_lifetimes from rustc_typeck#91882
Merged
bors merged 2 commits intorust-lang:masterfrom Dec 15, 2021
Merged
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. Please see the contribution instructions for more information. |
21 tasks
This comment has been minimized.
This comment has been minimized.
jackh726
approved these changes
Dec 14, 2021
Member
jackh726
left a comment
There was a problem hiding this comment.
A few comments. This needs a fmt, but otherwise it's really just nits.
r=me after fmt at least
| } | ||
|
|
||
| fn e0307(fcx: &FnCtxt<'fcx, 'tcx>, span: Span, receiver_ty: Ty<'_>) { | ||
| fn e0307<'fcx, 'tcx> (fcx: &FnCtxt<'fcx, 'tcx>, span: Span, receiver_ty: Ty<'_>) { |
Member
There was a problem hiding this comment.
I think reciver_ty should be Ty<'tcx> and then fcx be FnCtxt<'_, 'tcx>
Comment on lines
+1699
to
+1700
| impl CheckTypeWellFormedVisitor<'tcx> { | ||
| pub fn new(tcx: TyCtxt<'tcx>) -> CheckTypeWellFormedVisitor<'tcx> { | ||
| impl CheckTypeWellFormedVisitor<'_> { | ||
| pub fn new(tcx: TyCtxt<'_>) -> CheckTypeWellFormedVisitor<'_> { |
Member
There was a problem hiding this comment.
I don't think this change is better
| } | ||
|
|
||
| impl ItemLikeVisitor<'v> for CheckVisitor<'tcx> { | ||
| impl <'v, 'tcx> ItemLikeVisitor<'v> for CheckVisitor<'tcx> { |
Member
There was a problem hiding this comment.
Can probably do ItemLikeVisitor<'_> instead
| } | ||
|
|
||
| fn visit_implementation_of_coerce_unsized(tcx: TyCtxt<'tcx>, impl_did: LocalDefId) { | ||
| fn visit_implementation_of_coerce_unsized(tcx: TyCtxt<'_>, impl_did: LocalDefId) { |
Contributor
Author
There was a problem hiding this comment.
I tried to mostly follow the conventions of surrounding functions, but the rest of the file, other than this function and the one who follows use 'tcx', so I've changed both to follow the rest of the file.
| } | ||
|
|
||
| impl ItemLikeVisitor<'v> for InherentCollect<'tcx> { | ||
| impl<'v, 'tcx> ItemLikeVisitor<'v> for InherentCollect<'tcx> { |
| } | ||
|
|
||
| impl ItemLikeVisitor<'v> for InherentOverlapChecker<'tcx> { | ||
| impl<'v, 'tcx> ItemLikeVisitor<'v> for InherentOverlapChecker<'tcx> { |
| impl<'tcx> UnsafetyChecker<'tcx> { | ||
| fn check_unsafety_coherence<'v>( | ||
| &mut self, | ||
| item: &'v hir::Item<'v>, |
| } | ||
|
|
||
| impl ItemLikeVisitor<'v> for UnsafetyChecker<'tcx> { | ||
| impl<'v, 'tcx> ItemLikeVisitor<'v> for UnsafetyChecker<'tcx> { |
Member
|
@Patrick-Poitras You can run |
Member
|
@bors r+ |
Collaborator
|
📌 Commit a586e7d has been approved by |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2021
…times-from-rustc-typeck, r=jackh726 Remove `in_band_lifetimes` from `rustc_typeck` Joining in on the effort to remove the `in_band_lifetimes` features, as described in issue rust-lang#91867.
This was referenced Dec 14, 2021
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2021
…times-from-rustc-typeck, r=jackh726 Remove `in_band_lifetimes` from `rustc_typeck` Joining in on the effort to remove the `in_band_lifetimes` features, as described in issue rust-lang#91867.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2021
…times-from-rustc-typeck, r=jackh726 Remove `in_band_lifetimes` from `rustc_typeck` Joining in on the effort to remove the `in_band_lifetimes` features, as described in issue rust-lang#91867.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2021
…times-from-rustc-typeck, r=jackh726 Remove `in_band_lifetimes` from `rustc_typeck` Joining in on the effort to remove the `in_band_lifetimes` features, as described in issue rust-lang#91867.
This was referenced Dec 14, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90939 (Tweak errors coming from `for`-loop, `?` and `.await` desugaring) - rust-lang#91859 (Iterator::cycle() — document empty iterator special case) - rust-lang#91868 (Use `OutputFilenames` to generate output file for `-Zllvm-time-trace`) - rust-lang#91870 (Revert setting a default for the MACOSX_DEPLOYMENT_TARGET env var for linking) - rust-lang#91881 (Stabilize `iter::zip`) - rust-lang#91882 (Remove `in_band_lifetimes` from `rustc_typeck`) - rust-lang#91940 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Joining in on the effort to remove the
in_band_lifetimesfeatures, as described in issue #91867.