Improve 'cannot contain emoji' error.#91476
Conversation
|
First of all, this is my new favorite PR. Small editorial comment.I suggest making "Ferris" lowercase, both to match standard convention and to align it with the structured suggestion. If you disagree, feel free to disregard this. |
|
Ferris is a name, so I think the current capitalization is more accurate ;) |
|
@bors r+ |
|
📌 Commit 9d535b4 has been approved by |
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#91042 (Use Vec extend instead of repeated pushes on several places) - rust-lang#91476 (Improve 'cannot contain emoji' error.) - rust-lang#91568 (Pretty print break and continue without redundant space) - rust-lang#91645 (Implement `core::future::join!`) - rust-lang#91666 (update Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
This was widely stopping rust adoption for me, Thank you. |
I think this pull request may have won the Internet. |
|
I think we need more bullshit like this. Next step would be including the whole gemoji crate into compiler codebase to be able to name any emoji, not just Ferris only. |
|
The capitalization in the suggestions seems off when you don’t use it for a variable. E.g. in a or a |
I think this is sarcastic but it would sure be fun! |
|
what the.... |
|
@m-ou-se Any chance we get 🦀 as the only allowed emoji identifier? |
|
@arthurfiorette that would require t-lang sign-off. It would be too whimsical to do so, but I'm not against whimsy. |
|
I'm not familiar with the rust "workflow" for it... How can I start the process to get a t-lang sign-off? 😁 |
|
Adding 🦀 as an accepted identifier in Rust means removing this easter-egg, though. ^^ |
Before:
After:
r? @estebank