Simplify --no-headless option for rustdoc-gui tester#91391
Simplify --no-headless option for rustdoc-gui tester#91391bors merged 1 commit intorust-lang:masterfrom
Conversation
|
Sorry, I'm not familiar with the GUI tester. r? @jsha |
|
r? @notriddle |
|
I'm not very familiar with how this tool works, either. |
|
r? @jsha |
|
I'm not sure if @jsha is either. Oh well, we'll see. :) |
|
BTW, this does seem like a reasonable change to me. If you're using a "headed" browser, running more than one test at a time can create window-manager-related bugs, and nobody wants to deal with that. |
|
It was actually already the case, I simply added some log about it and unified the code a bit more. |
|
I'm okay reviewing this. I've looked a little bit at the GUI tester and have done some Node before. |
|
Don't hesitate if you have questions then! |
|
@bors r+ rollup Looks good! One comment on variable naming, which doesn't block merging: When I see a statement like this I read it as "not no headless", which is a double negative and kind of confusing. Instead you can name the variable |
|
📌 Commit 1feeda8 has been approved by |
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#91367 (Fix ICE in `check_must_not_suspend_ty()`) - rust-lang#91391 (Simplify --no-headless option for rustdoc-gui tester) - rust-lang#91537 (compiler/rustc_target: make m68k-unknown-linux-gnu use the gnu base) - rust-lang#91554 (Update doc about code block edition attributes) - rust-lang#91563 (Bump download-ci-llvm-stamp for LLD inclusion) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…tester-code, r=jsha Improve code for rustdoc-gui tester Following advice given in rust-lang#91391. It nicely improves the code readability. :) r? `@jsha`
It adds a message stating the change for the concurrency and also remove the extra condition when running the tests.
r? @camelid