rustdoc: Remove ResolvedPath.did#91195
Merged
bors merged 4 commits intorust-lang:masterfrom Nov 25, 2021
Merged
Conversation
Before, if `register_res` were called on an associated item or enum variant, it would return the parent's `DefId`. Now, it returns the actual `DefId`. This change is a step toward removing `Type::ResolvedPath.did` and potentially removing `kind_side_channel` in rustdoc. It also just simplifies rustdoc's behavior.
jyn514
reviewed
Nov 24, 2021
Member
jyn514
left a comment
There was a problem hiding this comment.
I'm not really comfortable approving this ... I like the idea in theory, but it seems very strange that none of the tests broke, and I worry something has broken without us realizing.
Member
Author
I'm not sure if it's very strange; I did update the href code (which IIRC caused lots of tests to fail before I updated it). |
Member
Collaborator
|
📌 Commit 4365112 has been approved by |
Member
|
Oh, it would be nice to fix #91195 (comment) either here or in a follow up though. |
Member
|
And I forgot about #91195 (comment) 🤦 r=me with those two done though @bors r- |
Co-authored-by: Joshua Nelson <github@jyn.dev>
Member
Author
|
@bors r=jyn514 rollup=iffy (to make bisecting easier if necessary) |
Collaborator
|
📌 Commit 617bbb2 has been approved by |
Collaborator
|
⌛ Testing commit 617bbb2 with merge 49b989201328d8a1714cffe31906a0a40ad92044... |
Collaborator
|
💔 Test failed - checks-actions |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
@bors retry |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (862962b): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Member
Author
|
Instructions improvements up to -0.1% and max-rss improvements up to -1% on doc builds :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResolvedPath.didwas not actually the same as.path.def_id(). Instead,.didreferred to theDefIdof the page to be used as a hyperlink target.For example, a link to
Struct::method()would useStruct'sDefIdas its.didfield. This behavior is confusing, easy to accidentally misuse, and caninstead be obtained on-demand when computing hyperlink targets. It's also likely
part of the reason
kind_side_channelexists. I'm currently working on someexperimental refactorings in
collect_intra_doc_linksthat I believe require --or at least benefit from -- removing
.did.r? @jyn514