Suggestion to wrap inner types using 'allocator_api' in tuple#90856
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 23, 2021
ken-matsui:suggestion-to-wrap-vec-allocator-api-in-tuple
Merged
Suggestion to wrap inner types using 'allocator_api' in tuple#90856bors merged 1 commit intorust-lang:masterfrom ken-matsui:suggestion-to-wrap-vec-allocator-api-in-tuple
bors merged 1 commit intorust-lang:masterfrom
ken-matsui:suggestion-to-wrap-vec-allocator-api-in-tuple
Conversation
Contributor
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
|
I don't understand what it's suggesting. Perhaps to replace |
Contributor
looking at #83250 makes it more obvious that it is suggesting |
fbstj
reviewed
Nov 13, 2021
davidtwco
requested changes
Nov 15, 2021
davidtwco
requested changes
Nov 16, 2021
Member
davidtwco
left a comment
There was a problem hiding this comment.
This is looking much better, thanks for addressing those comments, a few more changes.
davidtwco
reviewed
Nov 16, 2021
This comment has been minimized.
This comment has been minimized.
davidtwco
approved these changes
Nov 23, 2021
Member
davidtwco
left a comment
There was a problem hiding this comment.
Looks good, thanks for your work on this.
Member
|
@bors r+ |
Collaborator
|
📌 Commit 57494f7 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 23, 2021
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#90856 (Suggestion to wrap inner types using 'allocator_api' in tuple) - rust-lang#91103 (Inhibit clicks on summary's children) - rust-lang#91137 (Give people a single link they can click in the contributing guide) - rust-lang#91140 (Split inline const to two feature gates and mark expression position inline const complete) - rust-lang#91148 (Use `derive_default_enum` in the compiler) - rust-lang#91153 (kernel_copy: avoid panic on unexpected OS error) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Dec 11, 2021
|
Awesome. Thanks for getting to this even before I found out lol. Rust team is awesome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a suggestion to wrap the inner types in tuple when being along with 'allocator_api'.
Closes #83250
error[E0658]: use of unstable library feature 'allocator_api' --> $DIR/suggest-vec-allocator-api.rs:2:23 | LL | let _vec: Vec<u8, _> = vec![]; - | ^ + | ----^ + | | + | help: consider wrapping the inner types in tuple: `(u8, _)` | = note: see issue #32838 <https://github.com/rust-lang/rust/issues/32838> for more information = help: add `#![feature(allocator_api)]` to the crate attributes to enable