Fix a format_args span to be expansion#90131
Conversation
|
Hmm the change to diagnostics is probably not acceptable. It would be nice to detect the scenario when the rvalue behind the |
d654a4f to
c25df52
Compare
|
Using |
This comment has been minimized.
This comment has been minimized.
c25df52 to
4cfb7ad
Compare
| | | ||
| = note: this error originates in the macro `$crate::format_args_nl` (in Nightly builds, run with -Z macro-backtrace for more info) |
There was a problem hiding this comment.
This new output seems non-ideal, but there's probably not a good way to hide it. I guess it could potentially be useful if/when -Z macro-backtrace is stabilized?
There was a problem hiding this comment.
Not great but there are other instances like this.
|
@m-ou-se can I bother you for a review? The wrong span context is causing surprising behavior in Clippy. |
|
Oh, sorry for the delay. I don't think I'm the right person to review this though. Maybe someone from the compiler team? r? rust-lang/compiler |
|
Since the |
|
📌 Commit 4cfb7ad has been approved by |
|
⌛ Testing commit 4cfb7ad with merge 8d6f1889b234af193a3700ec9b8f2064bcd81f63... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
|
@bors retry |
|
⌛ Testing commit 4cfb7ad with merge c8b3a2be048338a8aff2389252c33c9e01493415... |
|
💔 Test failed - checks-actions |
|
@bors retry |
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#90131 (Fix a format_args span to be expansion) - rust-lang#90832 (Add 1.57.0 release notes) - rust-lang#90833 (Emit LLVM optimization remarks when enabled with `-Cremark`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
I found this while exploring solutions for rust-lang/rust-clippy#7843.
r? @m-ou-se