Add test case for using slice::fill with MaybeUninit#88507
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 3, 2021
Merged
Add test case for using slice::fill with MaybeUninit#88507bors merged 2 commits intorust-lang:masterfrom
slice::fill with MaybeUninit#88507bors merged 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon. Please see the contribution instructions for more information. |
RalfJung
reviewed
Aug 31, 2021
library/core/tests/slice.rs
Outdated
| #[test] | ||
| fn test_slice_fill_with_uninit() { | ||
| // This should not UB. See #87891 | ||
| use core::mem::MaybeUninit; |
Member
There was a problem hiding this comment.
Please put this use at the top of the file.
Member
|
Thanks! |
Collaborator
|
📌 Commit 5390ea4 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 3, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#88202 (Add an example for deriving PartialOrd on enums) - rust-lang#88483 (Fix LLVM libunwind build for non-musl targets) - rust-lang#88507 (Add test case for using `slice::fill` with MaybeUninit) - rust-lang#88557 (small const generics cleanup) - rust-lang#88579 (remove redundant / misplaced sentence from docs) - rust-lang#88610 (Update outdated docs of array::IntoIter::new.) - rust-lang#88613 (Update primitive docs for rust 2021.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test for #87891
Looks alright? @RalfJung
Fixes #87891