Add long explanation for E0726 by codekidX · Pull Request #87655 · rust-lang/rust

codekidX · 2021-07-31T10:28:33Z

Hey, I think some refactoring of codebase has occurred so the guidance mentioned in #61137 is not updated I think @GuillaumeGomez .

Please let me know if any other changes needs to be added to this PR.

rust-highfive · 2021-07-31T10:28:35Z

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

rust-highfive · 2021-07-31T10:28:36Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @LeSeulArtichaut (or someone else) soon.

Please see the contribution instructions for more information.

GuillaumeGomez · 2021-07-31T10:32:03Z

compiler/rustc_error_codes/src/error_codes/E0726.md

Suggested change

```rust

```compile_fail,E0726

GuillaumeGomez · 2021-07-31T10:32:39Z

compiler/rustc_error_codes/src/error_codes/E0726.md

The explanation is a bit lacking no? Maybe try to explain a bit more.

Also, please add a working version of the code example from above.

GuillaumeGomez

The explanation needs to be extending (lifetimes are far from an easy topic in rust) and you also need to add a working version of your previous failing code example.

GuillaumeGomez · 2021-07-31T10:35:04Z

compiler/rustc_error_codes/src/error_codes.rs

You need to remove E0725 from the list of error codes from below (it's not supposed to be declared twice in this file).

Urgau · 2021-07-31T10:38:18Z

compiler/rustc_error_codes/src/error_codes.rs

It's also 726 and not 725.

Suggested change

E0725: include_str!("./error_codes/E0726.md"),

E0726: include_str!("./error_codes/E0726.md"),

codekidX · 2021-07-31T18:02:13Z

@GuillaumeGomez does E0726 it not have a test case? if not, where should I add it?

codekidX · 2021-08-05T04:22:18Z

hey @GuillaumeGomez, I have added detailed explanation, please take a look.

Also the test is failing as

Some errors have detailed explanations: E0277, E0726.
For more information about an error, try `rustc --explain E0277`.

it should be

Some errors have detailed explanations: E0726.

right?

Since its itself E0277. Do let me know if this is an issue or I need to add E0277 above as well.

GuillaumeGomez · 2021-08-05T08:46:48Z

compiler/rustc_error_codes/src/error_codes/E0726.md

Please write a short summary of the error here, the explanation goes below. :)

Something like "An argument's lifetime was elided in an async function".

GuillaumeGomez · 2021-08-05T08:49:21Z

@GuillaumeGomez does E0726 it not have a test case? if not, where should I add it?

In src/test/ui/error_codes/ (there are a few others in this folder too so you can check how it works).

For the failing ui test, simply run it with --bless and let the tester do its job. ;)

GuillaumeGomez · 2021-08-05T08:50:10Z

compiler/rustc_error_codes/src/error_codes/E0726.md

Why do you need a method btw? Shouldn't an async function be enough?

GuillaumeGomez · 2021-08-05T08:50:31Z

compiler/rustc_error_codes/src/error_codes/E0726.md

No need to declare a main function, please remove it (but keep its content!).

GuillaumeGomez · 2021-08-05T08:51:08Z

compiler/rustc_error_codes/src/error_codes/E0726.md

Please add a working version of your example above.

bors · 2021-08-08T19:46:40Z

☔ The latest upstream changes (presumably #87697) made this pull request unmergeable. Please resolve the merge conflicts.

JohnCSimon · 2021-09-06T08:15:30Z

Ping from triage:
@codekidX can you please address the merge conflicts and build failures. Thank you.

JohnCSimon · 2021-09-27T05:42:14Z

Ping again from triage:
@codekidX can you please address the merge conflicts and build failures. Thank you.

codekidX · 2021-09-27T06:01:17Z

@JohnCSimon I'll rebase and resolve comments by today. Had some busy weeks, thanks for waiting.

rust-log-analyzer · 2021-09-28T05:00:19Z

The job x86_64-gnu-llvm-10 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

To only update this specific test, also pass `--test-args issues/issue-10412.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-10412.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-10412" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-10412/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
error: lifetimes cannot use keyword names
  --> /checkout/src/test/ui/issues/issue-10412.rs:1:20
   |
LL | trait Serializable<'self, T> { //~ ERROR lifetimes cannot use keyword names

error: lifetimes cannot use keyword names
  --> /checkout/src/test/ui/issues/issue-10412.rs:2:25
   |
   |
LL |     fn serialize(val : &'self T) -> Vec<u8>; //~ ERROR lifetimes cannot use keyword names

error: lifetimes cannot use keyword names
  --> /checkout/src/test/ui/issues/issue-10412.rs:3:38
   |
   |
LL |     fn deserialize(repr : &[u8]) -> &'self T; //~ ERROR lifetimes cannot use keyword names

error: lifetimes cannot use keyword names
  --> /checkout/src/test/ui/issues/issue-10412.rs:6:6
   |
   |
LL | impl<'self> Serializable<str> for &'self str { //~ ERROR lifetimes cannot use keyword names

error: lifetimes cannot use keyword names
  --> /checkout/src/test/ui/issues/issue-10412.rs:6:36
   |
   |
LL | impl<'self> Serializable<str> for &'self str { //~ ERROR lifetimes cannot use keyword names

error: lifetimes cannot use keyword names
  --> /checkout/src/test/ui/issues/issue-10412.rs:10:25
   |
   |
LL |     fn serialize(val : &'self str) -> Vec<u8> { //~ ERROR lifetimes cannot use keyword names

error: lifetimes cannot use keyword names
  --> /checkout/src/test/ui/issues/issue-10412.rs:13:37
   |
   |
LL |     fn deserialize(repr: &[u8]) -> &'self str { //~ ERROR lifetimes cannot use keyword names


error[E0726]: implicit elided lifetime not allowed here
   |
   |
LL | impl<'self> Serializable<str> for &'self str { //~ ERROR lifetimes cannot use keyword names
   |             ^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `Serializable<'_, str>`
   |
   = note: assuming a `'static` lifetime...
error[E0277]: the size for values of type `str` cannot be known at compilation time
  --> /checkout/src/test/ui/issues/issue-10412.rs:6:13
   |
   |
LL | impl<'self> Serializable<str> for &'self str { //~ ERROR lifetimes cannot use keyword names
   |
   = help: the trait `Sized` is not implemented for `str`
note: required by a bound in `Serializable`
  --> /checkout/src/test/ui/issues/issue-10412.rs:1:27
  --> /checkout/src/test/ui/issues/issue-10412.rs:1:27
   |
LL | trait Serializable<'self, T> { //~ ERROR lifetimes cannot use keyword names
   |                           ^ required by this bound in `Serializable`
help: consider relaxing the implicit `Sized` restriction
   |
LL | trait Serializable<'self, T: ?Sized> { //~ ERROR lifetimes cannot use keyword names

error: aborting due to 9 previous errors

Some errors have detailed explanations: E0277, E0726.
---
test result: FAILED. 12098 passed; 1 failed; 115 ignored; 0 measured; 0 filtered out; finished in 127.22s



command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "ui" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-10/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python3" "--lldb-python" "/usr/bin/python3" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "10.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker engine executionengine frontendopenmp fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcerror orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--channel" "nightly" "--color" "always"


Build completed unsuccessfully in 0:12:58

bors · 2021-11-05T19:20:10Z

☔ The latest upstream changes (presumably #90616) made this pull request unmergeable. Please resolve the merge conflicts.

jyn514 · 2021-11-18T14:58:54Z

Hi @apiraino, why did you add T-rustdoc here? This is a compiler error, rustdoc doesn't introduce any error codes that I know of.

apiraino · 2021-11-18T17:38:50Z

why did you add T-rustdoc here? This is a compiler error, rustdoc doesn't introduce any error codes that I know of.

@jyn514 I sweep the repository and assign the relevant T-* labels when missing. Here I have assigned the wrong one.

I probably didn't have clear the context and having seen a review from Guillaume tricked me into assuming that t-rustdoc had a say on this. Sorry, I hope that didn't cause any issue!

jyn514 · 2021-11-18T17:58:07Z

@apiraino no worries, I changed it to the right label :)

jyn514 · 2021-11-24T15:32:32Z

Hi @codekidX, do you know how to fix the CI error? I think you just need to pass --bless to the tests :) feel free to ask me here or on Zulip if you're having trouble!

ThrashAbaddon · 2021-12-14T11:21:48Z

bump!

JohnCSimon · 2022-02-27T19:09:49Z

@codekidX
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this. Thanks for your contribution.

@rustbot label: +S-inactive

…=Urgau Add long explanation for E0726 This is the cleaned up version of rust-lang#87655 with the missing fixes. Part of rust-lang#61137. r? `@Urgau`

rust-highfive assigned LeSeulArtichaut Jul 31, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2021

GuillaumeGomez reviewed Jul 31, 2021

View reviewed changes

GuillaumeGomez requested changes Jul 31, 2021

View reviewed changes

GuillaumeGomez reviewed Jul 31, 2021

View reviewed changes

Urgau reviewed Jul 31, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

LeSeulArtichaut assigned GuillaumeGomez and unassigned LeSeulArtichaut Jul 31, 2021

This comment has been minimized.

Sign in to view

GuillaumeGomez reviewed Aug 5, 2021

View reviewed changes

compiler/rustc_error_codes/src/error_codes/E0726.md Outdated

Copy link

Member

GuillaumeGomez Aug 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a working version of your example above.

jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2021

Add long explanation for E0726

4336f9d

E0726: fix example and short description

bfdaf67

This comment has been minimized.

Sign in to view

E0726: accepted wrong change on rebase conflict

6fe2ef5

apiraino added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 14, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 31, 2021

GuillaumeGomez mentioned this pull request Nov 4, 2021

Add missing long error code explanations #61137

Closed

100 tasks

jyn514 added A-error-codes Area: Explanation of an error code (--explain) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 18, 2021

jyn514 closed this Nov 18, 2021

jyn514 reopened this Nov 18, 2021

jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2021

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 12, 2021

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 30, 2022

JohnCSimon closed this Feb 27, 2022

rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Feb 27, 2022

GuillaumeGomez mentioned this pull request Feb 28, 2022

Add long explanation for E0726 #94449

Merged

	E0725: include_str!("./error_codes/E0726.md"),
	E0726: include_str!("./error_codes/E0726.md"),

Uh oh!

Conversation

codekidX commented Jul 31, 2021

Uh oh!

rust-highfive commented Jul 31, 2021

Uh oh!

rust-highfive commented Jul 31, 2021

Uh oh!

GuillaumeGomez Jul 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

codekidX commented Jul 31, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

codekidX commented Aug 5, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Aug 5, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bors commented Aug 8, 2021

Uh oh!

JohnCSimon commented Sep 6, 2021

Uh oh!

JohnCSimon commented Sep 27, 2021

Uh oh!

codekidX commented Sep 27, 2021

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 28, 2021

Uh oh!

bors commented Nov 5, 2021

Uh oh!

jyn514 commented Nov 18, 2021

Uh oh!

apiraino commented Nov 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jyn514 commented Nov 18, 2021

Uh oh!

jyn514 commented Nov 24, 2021

Uh oh!

ThrashAbaddon commented Dec 14, 2021

Uh oh!

JohnCSimon commented Feb 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

GuillaumeGomez Jul 31, 2021 •

edited

Loading

apiraino commented Nov 18, 2021 •

edited

Loading