typeck: Don't suggest converting LHS exprs by osa1 · Pull Request #81325 · rust-lang/rust

osa1 · 2021-01-24T07:39:05Z

Converting LHS of an assignment does not work, so avoid suggesting that.

Fixes #81293

rust-highfive · 2021-01-24T07:39:08Z

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

src/test/ui/typeck/issue-81293.stderr

estebank · 2021-01-25T06:17:13Z

@bors r+ rollup r? @estebank

bors · 2021-01-25T06:17:15Z

📌 Commit dbd76d2899f9f607992bb95c8e708d0fbd91fd2e has been approved by estebank

bors · 2021-01-25T06:17:25Z

⌛ Testing commit dbd76d2899f9f607992bb95c8e708d0fbd91fd2e with merge 117e736720c754012003706953f6ed1da73f388c...

rust-log-analyzer · 2021-01-25T06:43:11Z

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    Checking crates-io v0.31.1 (/tmp/cargo/crates/crates-io)
error[E0283]: type annotations needed
   --> src/cargo/util/config/de.rs:530:63
    |
530 |                 seed.deserialize(Tuple2Deserializer(1i32, env.as_ref()))
    |                                                           |   |
    |                                                           |   |
    |                                                           |   cannot infer type for type parameter `T` declared on the trait `AsRef`
    |                                                           this method call resolves to `&T`
    |
    = note: cannot satisfy `std::string::String: AsRef<_>`
help: use the fully qualified path for the potential candidates
    |
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<OsStr>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<std::path::Path>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<str>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<[u8]>>::as_ref(env)))

error: aborting due to previous error

For more information about this error, try `rustc --explain E0283`.

bors · 2021-01-25T06:45:26Z

💔 Test failed - checks-actions

osa1 · 2021-01-25T06:59:23Z

Is the failure above related to this patch, or is it some other patch in the batch? The error seems unrelated.

estebank · 2021-01-25T07:18:28Z

I don't think this was caused by your PR.

@bors retry

bors · 2021-01-25T07:38:12Z

⌛ Testing commit dbd76d2899f9f607992bb95c8e708d0fbd91fd2e with merge 5f281350a6283b676e5fdde141cba72f80d31c02...

rust-log-analyzer · 2021-01-25T08:02:29Z

The job dist-x86_64-linux-alt failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    Checking rustfix v0.5.1
error[E0283]: type annotations needed
   --> src/cargo/util/config/de.rs:530:63
    |
530 |                 seed.deserialize(Tuple2Deserializer(1i32, env.as_ref()))
    |                                                           |   |
    |                                                           |   |
    |                                                           |   cannot infer type for type parameter `T` declared on the trait `AsRef`
    |                                                           this method call resolves to `&T`
    |
    = note: cannot satisfy `std::string::String: AsRef<_>`
help: use the fully qualified path for the potential candidates
    |
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<OsStr>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<std::path::Path>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<str>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<[u8]>>::as_ref(env)))

error: aborting due to previous error

For more information about this error, try `rustc --explain E0283`.

bors · 2021-01-25T08:04:54Z

💔 Test failed - checks-actions

osa1 · 2021-01-25T08:43:58Z

🤔 do we need to remove the problematic patch from the batch maybe? Where can I see the commits/PRs in the failing batch?

estebank · 2021-01-26T00:52:08Z

@osa1 let's try rebasing on top of a recent master and force pushing

Converting LHS of an assignment does not work, so avoid suggesting that. Fixes #81293

osa1 · 2021-01-26T06:09:50Z

@bors retry

bors · 2021-01-26T06:09:51Z

@osa1: 🔑 Insufficient privileges: not in try users

tgnottingham · 2021-01-26T07:12:23Z

@bors retry

estebank · 2021-01-26T17:06:48Z

@bors r+

Rebases require a new approval (as you could have put different code after the review, the approvals are tied to git sha).

bors · 2021-01-26T17:06:49Z

📌 Commit d035be8 has been approved by estebank

bors · 2021-01-26T17:06:50Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Rollup of 14 pull requests Successful merges: - rust-lang#80812 (Update RELEASES.md for 1.50.0) - rust-lang#80876 (Add `unwrap_unchecked()` methods for `Option` and `Result`) - rust-lang#80900 (Fix ICE with `ReadPointerAsBytes` validation error) - rust-lang#81191 (BTreeMap: test all borrowing interfaces and test more chaotic order behavior) - rust-lang#81195 (Account for generics when suggesting bound) - rust-lang#81299 (Fix some bugs reported by eslint) - rust-lang#81325 (typeck: Don't suggest converting LHS exprs) - rust-lang#81353 (Fix spelling in documentation for error E0207) - rust-lang#81369 (rustc_codegen_ssa: use wall time for codegen_to_LLVM_IR time-passes entry) - rust-lang#81389 (rustdoc: Document CommonMark extensions.) - rust-lang#81399 (Update books) - rust-lang#81401 (tidy: Some code cleanup.) - rust-lang#81407 (Refine "remove semicolon" suggestion in trait selection) - rust-lang#81412 (Fix assertion in `MaybeUninit::array_assume_init()` for zero-length arrays) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned varkor Jan 24, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 24, 2021

osa1 commented Jan 24, 2021

View reviewed changes

src/test/ui/typeck/issue-81293.stderr Outdated Show resolved Hide resolved

rust-highfive assigned estebank and unassigned varkor Jan 25, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 25, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 25, 2021

typeck: Don't suggest converting LHS exprs

d035be8

Converting LHS of an assignment does not work, so avoid suggesting that. Fixes #81293

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2021

JohnTitor mentioned this pull request Jan 26, 2021

Rollup of 14 pull requests #81417

Merged

bors merged commit 71f13fb into rust-lang:master Jan 26, 2021

rustbot added this to the 1.51.0 milestone Jan 26, 2021

camelid mentioned this pull request Jan 28, 2021

Integer mismatch incorrectly suggests T::from() as LHS of assignment #79756

Closed

osa1 deleted the issue81293 branch February 1, 2021 06:15

Uh oh!

Conversation

osa1 commented Jan 24, 2021

Uh oh!

rust-highfive commented Jan 24, 2021

Uh oh!

Uh oh!

estebank commented Jan 25, 2021

Uh oh!

bors commented Jan 25, 2021

Uh oh!

bors commented Jan 25, 2021

Uh oh!

rust-log-analyzer commented Jan 25, 2021

Uh oh!

bors commented Jan 25, 2021

Uh oh!

osa1 commented Jan 25, 2021

Uh oh!

estebank commented Jan 25, 2021

Uh oh!

bors commented Jan 25, 2021

Uh oh!

rust-log-analyzer commented Jan 25, 2021

Uh oh!

bors commented Jan 25, 2021

Uh oh!

osa1 commented Jan 25, 2021

Uh oh!

estebank commented Jan 26, 2021

Uh oh!

osa1 commented Jan 26, 2021

Uh oh!

bors commented Jan 26, 2021

Uh oh!

tgnottingham commented Jan 26, 2021

Uh oh!

estebank commented Jan 26, 2021

Uh oh!

bors commented Jan 26, 2021

Uh oh!

bors commented Jan 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants