Clean bootstrap artifacts on x.py clean#80574
Conversation
|
@bors r+ rollup |
|
📌 Commit 139ef75 has been approved by |
Rollup of 6 pull requests Successful merges: - rust-lang#80546 (clippy fixes for librustdoc) - rust-lang#80555 (Improve library tracking issue template) - rust-lang#80574 (Clean bootstrap artifacts on `x.py clean`) - rust-lang#80578 (improve unconditional_panic description) - rust-lang#80599 (`const_generics_defaults`: don't ICE in the unimplemented parts) - rust-lang#80613 (Diag: print enum variant instead of enum type) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Will this mean that there's no way to just clean the library/compiler artifacts? |
|
Hm, I'd expect bootstrap to compile in around a minute, but I guess maybe it's grown over time. Probably we want some kind of flags or something... |
|
A minute is a lot, since |
@RalfJung you could run |
|
That said I guess a reasonable question might be - why do we want to clean bootstrap? It should be very reliably recompiled (unlike other artifacts some times) |
|
@jyn514 yeah that's what I used to do; `x.py clean is much shorter though. ;) @Mark-Simulacrum one good reason to clean bootstrap is to remove outdated artifacts. When the beta compiler gets bumped, the old files remain, so the bootstrap folder keeps growing and I sometims remove it manually. I do that much less often than |
|
It seems like we could delete the bootstrap build directory when the bootstrap compiler changes without too much trouble. If that's the only reason to want to touch it, I think it's better. |
…r=Mark-Simulacrum Do not delete bootstrap.exe on Windows during clean Windows does not allow deleting currently running executables. This an addition to `@jyn514's` change in rust-lang#80574.
…r=Mark-Simulacrum Do not delete bootstrap.exe on Windows during clean Windows does not allow deleting currently running executables. This an addition to ``@jyn514's`` change in rust-lang#80574.
…r=Mark-Simulacrum Do not delete bootstrap.exe on Windows during clean Windows does not allow deleting currently running executables. This an addition to ```@jyn514's``` change in rust-lang#80574.
Closes #76519
r? @Mark-Simulacrum