Upgrade to tracing-subscriber 0.2.13#77678
Conversation
|
This found a bug in the test suite! |
|
Looking at that test, the proposed change makes it useless, and it could just be deleted. I think we should do that. (#18075 is the issue it was tracking, and that issue looks unlikely to reoccur anyway). |
|
I could change it to |
|
I don't think that helps personally, the test is just likely no longer useful. We can prune it. |
The primary motivation is to get the changes from tokio-rs/tracing#990. Example output: ``` $ RUSTDOC_LOG=debug rustdoc +rustc2 warning: some trace filter directives would enable traces that are disabled statically | `debug` would enable the DEBUG level for all targets = note: the static max level is `info` = help: to enable DEBUG logging, remove the `max_level_info` feature ``` - Remove useless test This was testing for an ICE when passing `RUST_LOG=rustc_middle`. I noticed it because it started giving the tracing warning (because tests are not run with debug-logging enabled). Since this bug seems unlikely to re-occur, I just removed it altogether.
|
Ok, I removed the unhelpful test. |
|
I think this is good -- @bors r+ That said, it would be great if searching for max_level_info or "some trace filter directives would enable traces that are disabled statically" in CONTRIBUTING.md or rustc-dev-guide would immediately yield results on what to do -- right now that message is likely helpful in the sense that you know you have a problem, but you still don't know what to do to fix it :) Maybe we could include those two things in the config.toml.example by the debug-logging flag, too, which would make ripgrep in the repository for them yield something useful too. |
|
📌 Commit 8b22d07 has been approved by |
|
☀️ Test successful - checks-actions, checks-azure |
…crum Make `max_log_info` easily greppable (for figuring out why debug logging is disabled) Follow-up to rust-lang#77678 (comment). I'll make a PR to the dev-guide shortly changing `debug = true` to `debug-logging = true` and using this text. Ideally wouldn't be merged before rust-lang#77678, but it practice it won't hurt anything. r? @Mark-Simulacrum
The primary motivation is to get the changes from
tokio-rs/tracing#990. Example output:
r? @Mark-Simulacrum
cc @hawkw ❤️