give *even better* suggestion when matching a const range#76749
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 19, 2020
Merged
give *even better* suggestion when matching a const range#76749bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Contributor
Author
|
@rustbot modify labels +A-diagnostics +T-compiler |
estebank
reviewed
Sep 15, 2020
Contributor
estebank
left a comment
There was a problem hiding this comment.
Looks great! Some small nitpicks inline.
guswynn
commented
Sep 16, 2020
| if let Ok(snip) = | ||
| self.tcx.sess.source_map().span_to_snippet(span) | ||
| { | ||
| e.span_suggestion_verbose( |
Contributor
Author
There was a problem hiding this comment.
this is extremely nested, looks kindof funny lol
also let me know if there is a better way to get the snippet
Contributor
There was a problem hiding this comment.
I think that this is fine. At most, I would move this to a new method named along the lines of maybe_suggest_range_literal, simply to make it easier to follow what's going on at a high level.
estebank
approved these changes
Sep 16, 2020
Contributor
estebank
left a comment
There was a problem hiding this comment.
Some small changes left. Otherwise it looks good to me!
| if let Ok(snip) = | ||
| self.tcx.sess.source_map().span_to_snippet(span) | ||
| { | ||
| e.span_suggestion_verbose( |
Contributor
There was a problem hiding this comment.
I think that this is fine. At most, I would move this to a new method named along the lines of maybe_suggest_range_literal, simply to make it easier to follow what's going on at a high level.
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 230355f has been approved by |
Contributor
|
@bors rollup |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Sep 19, 2020
give *even better* suggestion when matching a const range notice that the err already has "constant defined here" so this is now *exceedingly clear* extension to rust-lang#76222 r? @estebank
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2020
Rollup of 14 pull requests Successful merges: - rust-lang#73963 (deny(unsafe_op_in_unsafe_fn) in libstd/path.rs) - rust-lang#75099 (lint/ty: move fns to avoid abstraction violation) - rust-lang#75502 (Use implicit (not explicit) rules for promotability by default in `const fn`) - rust-lang#75580 (Add test for checking duplicated branch or-patterns) - rust-lang#76310 (Add `[T; N]: TryFrom<Vec<T>>` (insta-stable)) - rust-lang#76400 (Clean up vec benches bench_in_place style) - rust-lang#76434 (do not inline black_box when building for Miri) - rust-lang#76492 (Add associated constant `BITS` to all integer types) - rust-lang#76525 (Add as_str() to string::Drain.) - rust-lang#76636 (assert ScalarMaybeUninit size) - rust-lang#76749 (give *even better* suggestion when matching a const range) - rust-lang#76757 (don't convert types to the same type with try_into (clippy::useless_conversion)) - rust-lang#76796 (Give a better error message when x.py uses the wrong stage for CI) - rust-lang#76798 (Build fixes for RISC-V 32-bit Linux support) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notice that the err already has "constant defined here"
so this is now exceedingly clear
extension to #76222
r? @estebank