Make the error messages that result from referencing nonexistent traits consistent, and add a test.#7572
Closed
Dretch wants to merge 2 commits intorust-lang:masterfrom
Dretch:missing-trait-message-followup
Closed
Make the error messages that result from referencing nonexistent traits consistent, and add a test.#7572Dretch wants to merge 2 commits intorust-lang:masterfrom Dretch:missing-trait-message-followup
Dretch wants to merge 2 commits intorust-lang:masterfrom
Dretch:missing-trait-message-followup
Conversation
nonexistent traits consistent, and add a test.
bors
added a commit
that referenced
this pull request
Jul 7, 2013
…cwalton This a followup to #7510. @catamorphism requested a test - so I have created one, but in doing so I noticed some inconsistency in the error messages resulting from referencing nonexistent traits, so I changed the messages to be more consistent.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 27, 2022
fix op_ref false positive fixes rust-lang#7572 changelog: `op_ref` don't lint for unnecessary reference in BinOp impl if removing the reference will lead to unconditional recursion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a followup to #7510. @catamorphism requested a test - so I have created one, but in doing so I noticed some inconsistency in the error messages resulting from referencing nonexistent traits, so I changed the messages to be more consistent.