Fixed documentation for finalize->drop change#7516
Closed
sfackler wants to merge 2 commits intorust-lang:masterfrom
Closed
Fixed documentation for finalize->drop change#7516sfackler wants to merge 2 commits intorust-lang:masterfrom
sfackler wants to merge 2 commits intorust-lang:masterfrom
Conversation
Now that the finalize->drop rename has happened, this hopefully shouldn't end up changing again.
Member
Author
|
Moving into #7549 |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 12, 2021
Add `unwrap_or_else_default` lint --- *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: Add a new [`unwrap_or_else_default`] style lint. This will catch `unwrap_or_else(Default::default)` on Result and Option and suggest `unwrap_or_default()` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should the warning about renaming be dropped now?