compiletest: Support ignoring tests requiring missing LLVM components#75064
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 2, 2020
Merged
compiletest: Support ignoring tests requiring missing LLVM components#75064bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Member
|
@bors r+ |
Collaborator
|
📌 Commit d3277b9 has been approved by |
Contributor
|
It might be a good idea to add a flag to assert that all needed components are available, to ensure that we don't accidentally stop running these tests entirely. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 2, 2020
…arth Rollup of 5 pull requests Successful merges: - rust-lang#74980 (pprust: adjust mixed comment printing and add regression test for rust-lang#74745) - rust-lang#75009 (Document the discrepancy in the mask type for _mm_shuffle_ps) - rust-lang#75031 (Do not trigger `unused_{braces,parens}` lints with `yield`) - rust-lang#75059 (fix typos) - rust-lang#75064 (compiletest: Support ignoring tests requiring missing LLVM components) Failed merges: r? @ghost
Contributor
Author
Addressed in #77280. |
bjorn3
reviewed
Sep 29, 2020
| //i686: define void @has_efiapi | ||
| //aarch64: define void @has_efiapi | ||
| //arm: define void @has_efiapi | ||
| //riscv: define void @has_efiapi |
Member
There was a problem hiding this comment.
You need to use CHECK for this, right?
Contributor
Author
There was a problem hiding this comment.
Maybe. I simply reverted #66084 here and didn't make any changes.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 30, 2020
…acrum Ensure that all LLVM components requested by tests are available on CI Addresses rust-lang#75064 (comment) I used an environment variable because passing a command line option all the way from CI to compiletest would be just too much hassle for this task. I added a new variable, but any of the already existing ones defined by CI could be used instead. r? @Mark-Simulacrum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a more principled solution to the problem described in #66084.
Builds of LLVM backends take a lot of time and disk space.
So it usually makes sense to build rustc with
unless you are working on some target-specific tasks.
A few tests, however, require non-x86 backends to be built.
A new test directive
// needs-llvm-components: component1 component2 component3makes such tests to be automatically ignored if one of the listed components is missing in the provided LLVM (this is determined throughllvm-config --components).As a result, the test suite now fully passes with LLVM built only with the x86 backend. The component list in this case is
(With the default target list it's much larger.)
#66084 is also reverted now.
r? @Mark-Simulacrum