Merged
Conversation
Contributor
|
579e51b to
9988ec0
Compare
Member
Author
|
Note that this is currently targeting tomorrow. I think that may be a bit of a rush to get done in time though, so it may be best to delay till Monday. If I don't see an r+ from @pnkfelix or another compiler team member tonight I'll edit for that. Also added in the track caller regression fix. I've put up a blog post PR at rust-lang/blog.rust-lang.org#661 |
9988ec0 to
1811fc7
Compare
We were missing an Instance::resolve_for_fn_ptr in resolve_for_vtable. Closes rust-lang#74764.
1811fc7 to
fcd1712
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit fcd1712 has been approved by |
Member
Author
|
@bors p=100 rollup=never |
Collaborator
Merged
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 31, 2020
…Mark-Simulacrum 1.45.2 release notes (for master) cc rust-lang#74958
Contributor
|
Confirming that applying these to 1.45.1 resolves #74954 and doesn't introduce any more problems. |
Member
Author
|
Gah I forgot to actually bump to 1.45.2 -- opened #74988 to do that. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 31, 2020
…imulacrum [stable] Update to 1.45.2 This just bumps the release number, which I forgot to do in the previous PR (rust-lang#74958). r? @ghost
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 31, 2020
…Mark-Simulacrum 1.45.2 release notes (for master) cc rust-lang#74958
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to fix the stable breakage noted in #74954, but does not close that issue -- there remains investigation and likely nightly/beta fixes need to be issued as well.
r? @pnkfelix