Merged
Conversation
kinnison
reviewed
May 30, 2020
Contributor
kinnison
left a comment
There was a problem hiding this comment.
I'm tempted to ask for a factoring of the clearing of the timeout into a function,but if you don't think it's worthwhile then this is clean afaict, but I'm unable to build compilers/rustdoc right now due to my desktop being fluffed and being out of disk space on my laptop. r=me with or without factoring the function out, thought I'd prefer it if you did.
Member
Author
|
I'll do it then. :) |
Member
Author
|
Updated! |
kinnison
approved these changes
May 31, 2020
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 7a2efa3 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 31, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#72691 (Fix escape key handling) - rust-lang#72807 (Avoid setting wrong obligation cause span of associated type mismatch) - rust-lang#72812 (Miri tests: skip parts of test_char_range) - rust-lang#72829 (Clarify terms in doc comments) - rust-lang#72830 (Fix release notes for niche initialization change) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72647.
The problem was that you could have a timeout just after the moment you press "escape", putting back the results.
r? @kinnison