Add comment for Ord implementation for array#71944
Merged
bors merged 1 commit intorust-lang:masterfrom May 6, 2020
Merged
Conversation
Contributor
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
I don't believe that comment will be displayed anywhere in the documentation, but if you move it down to the cmp method it will. |
Contributor
Author
Sorry, but it actually will be displayed after expanding the impl block. You can check https://doc.rust-lang.org/std/primitive.slice.html#impl-Ord and Lines 5795 to 5803 in 8da5869 |
Member
|
Oh, great! @bors r+ rollup |
Collaborator
|
📌 Commit 5087c1a has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#71269 (Define UB in float-to-int casts to saturate) - rust-lang#71591 (use new interface to create threads on HermitCore) - rust-lang#71819 (x.py: Give a more helpful error message if curl isn't installed) - rust-lang#71893 (Use the `impls` module to import pre-existing dataflow analyses) - rust-lang#71929 (Use -fvisibility=hidden for libunwind) - rust-lang#71937 (Ignore SGX on a few ui tests) - rust-lang#71944 (Add comment for `Ord` implementation for array) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding to
Ordimplementation for slice. It hints new comer the rule of comparing two arrays.