Unify lints handling in rustdoc#71581
Merged
bors merged 1 commit intorust-lang:masterfrom May 8, 2020
Merged
Conversation
kinnison
reviewed
Apr 26, 2020
Contributor
kinnison
left a comment
There was a problem hiding this comment.
While this is tidier, I think I'd benefit from a bit of documentation on the purpose and meaning of the arguments to, and results of, the init_lints() function. I appreciate the behaviour doesn't appear to have changed, but that doesn't mean I understand it.
Member
Author
|
Good point, thanks for bringing it up! I'll document the function to make it as clear as possible. |
3ef43a5 to
9ae85e1
Compare
Member
Author
|
I added more documentation to explain what's going on. |
kinnison
approved these changes
May 8, 2020
Contributor
|
That doc helps me understand a good bit better, thanks. @bors r+ |
Collaborator
|
📌 Commit 9ae85e1 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 8, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#71581 (Unify lints handling in rustdoc) - rust-lang#71710 (Test for zero-sized function items not ICEing) - rust-lang#71970 (Improve bitcode generation for Apple platforms) - rust-lang#71975 (Reduce `TypedArena` creations in `check_match`.) - rust-lang#72003 (allow wasm target for rustc-ap-rustc_span) - rust-lang#72017 (Work around ICEs during cross-compilation for target, ast, & attr) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small cleanup. The goal is to unify a bit things to make the reading simpler.
r? @kinnison
cc @rust-lang/rustdoc