Account for use of try!() in 2018 edition and guide users in the right direction#71243
Merged
bors merged 4 commits intorust-lang:masterfrom Apr 18, 2020
Merged
Account for use of try!() in 2018 edition and guide users in the right direction#71243bors merged 4 commits intorust-lang:masterfrom
try!() in 2018 edition and guide users in the right direction#71243bors merged 4 commits intorust-lang:masterfrom
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Author
|
I'm not sure how this works, should I pick @estebank since he opened the issue? |
|
r? @estebank |
estebank
reviewed
Apr 17, 2020
estebank
approved these changes
Apr 17, 2020
Contributor
estebank
left a comment
There was a problem hiding this comment.
It looks really good!
I left some nitpicks.
estebank
reviewed
Apr 17, 2020
estebank
reviewed
Apr 17, 2020
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 79abac8 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#70467 (Use `call` instead of `invoke` for functions that cannot unwind ) - rust-lang#71070 (rustbuild: Remove stage 0 LLD flavor workaround for MSVC) - rust-lang#71167 (big-O notation: parenthesis for function calls, explicit multiplication) - rust-lang#71238 (Miri: fix typo) - rust-lang#71242 (Format Mailmap To Work With GitHub) - rust-lang#71243 (Account for use of `try!()` in 2018 edition and guide users in the right direction) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #71155