Remove unused single_step flag#71128
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 15, 2020
Merged
Conversation
This appears to have never been used ever since its introduction in 61c7569 -- the plugin discussed on the PR introducing that commit, 34811, never materialized. It's also simple to readd in the current scheme, but given that macro expansion is already quite complicated, additional useless state seems good to remove while we're not using it.
Contributor
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
r? @petrochenkov @bors r+ rollup |
Collaborator
|
📌 Commit a0d4c74 has been approved by |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 14, 2020
…petrochenkov Remove unused single_step flag This appears to have never been used ever since its introduction in 61c7569 -- the plugin discussed on the PR introducing that commit, 34811, never materialized. It's also simple to re-add in the current scheme, but given that macro expansion is already quite complicated, additional useless state seems good to remove while we're not using it.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#70657 (Allow `try`-blocks in places where an open delim is expected) - rust-lang#70947 (tighten CTFE safety net for accesses to globals) - rust-lang#70949 (simplify `vec!` macro) - rust-lang#71002 (fix target & runtool args order) - rust-lang#71082 (ptr: introduce len() method on raw slices) - rust-lang#71128 (Remove unused single_step flag) - rust-lang#71133 (Tighten time complexity on the doc of sort_by_key) - rust-lang#71135 (Update books) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to have never been used ever since its introduction in 61c7569 --
the plugin discussed on the PR introducing that commit, 34811, never
materialized.
It's also simple to re-add in the current scheme, but given that macro expansion
is already quite complicated, additional useless state seems good to remove
while we're not using it.