syntax: correct the Rand::rand call to select enum variants in #[deriving(Rand)].#7101
Closed
huonw wants to merge 3 commits intorust-lang:incomingfrom
Closed
syntax: correct the Rand::rand call to select enum variants in #[deriving(Rand)].#7101huonw wants to merge 3 commits intorust-lang:incomingfrom
huonw wants to merge 3 commits intorust-lang:incomingfrom
Conversation
…ving(Rand)]. Previously, this was not a global call, and so when `#[deriving(Rand)]` was in any module other than the top-level one, it failed (unless there was a `use std;` in scope). Also, fix a minor inconsistency between uints and u32s for this piece of code.
Contributor
Author
Contributor
|
@huonw ping me after you rebase this to master. Sorry for the inconvenience; but at least there's a good chance this won't happen again. :) |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 22, 2021
Add flat_map_option lint changelog: Add flat_map_option lint Closes rust-lang#2241
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this was not a global call, and so when
#[deriving(Rand)]was in any module other than the top-level one, it failed (unless there
was a
use std;in scope).Also, fix a minor inconsistency between uints and u32s for this piece
of code.