Tweak output of type params and constraints in the wrong order#70519
Merged
bors merged 6 commits intorust-lang:masterfrom Apr 6, 2020
Merged
Tweak output of type params and constraints in the wrong order#70519bors merged 6 commits intorust-lang:masterfrom
bors merged 6 commits intorust-lang:masterfrom
Conversation
estebank
commented
Mar 29, 2020
estebank
commented
Mar 29, 2020
Centril
reviewed
Mar 29, 2020
When encountering constraints before type arguments or lifetimes, suggest the correct order.
Contributor
Author
|
One thing to keep in mind is that we suggest fixing the order, but we don't proactively fix it, leading to situations like the following: |
estebank
commented
Mar 29, 2020
Contributor
I think this is acceptable: it's still clear, just a little repetitive. |
Centril
reviewed
Mar 30, 2020
Using a single label for constraints and generic arguments.
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 17a9523 has been approved by |
Collaborator
|
⌛ Testing commit 17a9523 with merge d6ae20f50d7494dac10b3a779aa1014d7a40e0cf... |
Contributor
|
@bors retry |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#70519 (Tweak output of type params and constraints in the wrong order) - rust-lang#70704 (Make panic unwind the default for aarch64-*-windows-msvc targets) - rust-lang#70713 (Prefer sysroot from rustc in same directory as rust-gdb) - rust-lang#70739 (def_collector, visit_fn: account for no body) - rust-lang#70827 (Use smaller span for suggestion restricting lifetime) Failed merges: r? @ghost
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @Centril @varkor