Remove RefCell usage from ObligationForest.#68691
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 6, 2020
Merged
Conversation
nikomatsakis
approved these changes
Feb 5, 2020
Contributor
nikomatsakis
left a comment
There was a problem hiding this comment.
r=me modulo nit -- but feel free to ignore, I don't care
It's not needed.
215418a to
6ad725e
Compare
Contributor
Author
|
@bors rollup=always |
Contributor
Author
|
@bors r=nikomatsakis |
Collaborator
|
📌 Commit 6ad725e has been approved by |
Contributor
|
Is there even the need for |
Contributor
Author
I tried that, it leads to borrowck errors. |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 6, 2020
…ionForest, r=nikomatsakis Remove `RefCell` usage from `ObligationForest`. It's not needed. This doesn't affect performance, it just simplifies the code a little. r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Feb 6, 2020
Rollup of 9 pull requests Successful merges: - #68691 (Remove `RefCell` usage from `ObligationForest`.) - #68751 (Implement `unused_parens` for `const` and `static` items) - #68788 (Towards unified `fn` grammar) - #68837 (Make associated item collection a query) - #68842 (or_patterns: add regression test for #68785) - #68844 (use def_path_str for missing_debug_impls message) - #68845 (stop using BytePos for computing spans in librustc_parse/parser/mod.rs) - #68869 (clean up E0271 explanation) - #68880 (Forbid using `0` as issue number) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not needed.
This doesn't affect performance, it just simplifies the code a little.
r? @nikomatsakis