Increase spacing for suggestions in diagnostics#65773
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 26, 2019
Merged
Conversation
Make the spacing between the code snippet and verbose structured suggestions consistent with note and help messages.
Centril
reviewed
Oct 24, 2019
Contributor
Author
|
Pinging because this has high potential for bitrot due to extensive touching of stderr files. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 508d032 has been approved by |
Collaborator
|
⌛ Testing commit 508d032 with merge f6799d1079c3203f1a8a08bfbddd6dc4c6ca7679... |
Contributor
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - checks-azure |
Member
|
It's a network error. |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 26, 2019
Increase spacing for suggestions in diagnostics Make the spacing between the code snippet and verbose structured suggestions consistent with note and help messages. r? @Centril
bors
added a commit
that referenced
this pull request
Oct 26, 2019
Rollup of 8 pull requests Successful merges: - #65743 (rustc_typeck: don't record direct callees in generator_interior.) - #65761 (libsyntax: Enhance documentation of the AST module) - #65772 (Remove the last remaining READMEs) - #65773 (Increase spacing for suggestions in diagnostics) - #65791 (Adding doc on keyword continue) - #65824 (rustc: make DefPathData (and friends) Copy (now that it uses Symbol).) - #65828 (Derive Eq and Hash for SourceInfo again) - #65842 (Add more information on rustdoc search) Failed merges: - #65825 (rustc: use IndexVec<DefIndex, T> instead of Vec<T>.) r? @ghost
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Oct 26, 2019
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Oct 26, 2019
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Oct 26, 2019
Rustup to rust-lang/rust#65773 changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the spacing between the code snippet and verbose structured
suggestions consistent with note and help messages.
r? @Centril