rustdoc: forward -Z options to rustc#65314
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 21, 2019
Merged
Conversation
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Currently rustdoc does not forward `-Z` options to rustc when building test executables. This makes impossible to use rustdoc to run test samples when crate under test is instrumented with one of sanitizers `-Zsanitizer=...`, since the final linking step will not include sanitizer runtime library. Forward `-Z` options to rustc to solve the issue. Helps with rust-lang#43031.
Contributor
|
I also ran into this issue, and this fix appears to help in my case of testing some unstable cargo/rustc interaction. |
Contributor
|
Thanks. @bors r+ |
Collaborator
|
📌 Commit 5db1733 has been approved by |
Collaborator
|
⌛ Testing commit 5db1733 with merge 4a91f13cceeaacad3c831c6c6e31606a20042b69... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 20, 2019
rustdoc: forward -Z options to rustc Currently rustdoc does not forward `-Z` options to rustc when building test executables. This makes impossible to use rustdoc to run test samples when crate under test is instrumented with one of sanitizers `-Zsanitizer=...`, since the final linking step will not include sanitizer runtime library. Forward `-Z` options to rustc to solve the issue. Helps with rust-lang#43031.
Contributor
|
@bors retry rolled up. |
bors
added a commit
that referenced
this pull request
Oct 20, 2019
Rollup of 8 pull requests Successful merges: - #65314 (rustdoc: forward -Z options to rustc) - #65592 (clarify const_prop ICE protection comment) - #65603 (Avoid ICE when include! is used by stdin crate) - #65614 (Improve error message for APIT with explicit generic arguments) - #65629 (Remove `borrowck_graphviz_postflow` from test) - #65633 (Remove leading :: from paths in doc examples) - #65638 (Rename the default argument 'def' to 'default') - #65639 (Fix parameter name in documentation) Failed merges: r? @ghost
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently rustdoc does not forward
-Zoptions to rustc when buildingtest executables. This makes impossible to use rustdoc to run test
samples when crate under test is instrumented with one of sanitizers
-Zsanitizer=..., since the final linking step will not includesanitizer runtime library.
Forward
-Zoptions to rustc to solve the issue.Helps with #43031.